-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomizeディレクトリからSymfony Bundleをインストールできるよう修正 #6141
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6141 +/- ##
=======================================
Coverage 82.80% 82.80%
=======================================
Files 480 480
Lines 26431 26437 +6
=======================================
+ Hits 21885 21891 +6
Misses 4546 4546
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@kurozumi |
@kurozumi |
テストを追加しました。 |
@kurozumi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
概要(Overview・Refs Issue)
CustomizeディレクトリからSymfony BundleをインストールできるようKernel.phpを修正しました。
方針(Policy)
実装に関する補足(Appendix)
テスト(Test)
以下のコードでCustomizeディレクトリのBundleが読み込まれるのを確認しました。
app/Customize/Resource/config/bundles.php
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目