[4.2] インストーラでのプラグイン有効化/無効化時にキャッシュ削除が失敗する場合があるのを修正 #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
なんと |
chihiro-adachi
suggested changes
Sep 5, 2022
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public static function getSubscribedEvents() |
There was a problem hiding this comment.
@nanasess
このコントローラでの局所的な処理だと思うので、eventListenerで処理したほうがよいかなと思いました。
以下のような記述になります。
https://github.com/EC-CUBE/ProductImagesUploader/blob/4.2/Controller/Admin/ConfigController.php#L50
Codecov Report
@@ Coverage Diff @@
## 4.2 #5764 +/- ##
============================================
+ Coverage 78.84% 78.86% +0.01%
- Complexity 6273 6274 +1
============================================
Files 469 469
Lines 21058 21076 +18
============================================
+ Hits 16604 16621 +17
- Misses 4454 4455 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@nanasess 有効化/無効化を複数回繰り返し、システムエラーは発生しませんでした。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
fixes #5498
インストーラでのプラグイン有効化/無効化時にキャッシュ削除が失敗する場合があるのを修正
方針(Policy)
KernelEvents::TERMINATEでキャッシュファイルを強制的に物理削除する実装に関する補足(Appendix)
テスト（Test)
#5498 の再現手順の事象が再現しなくなるのを確認
相談（Discussion）
インストーラのE2Eテストが Step2 までしか無い...
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目