ref #5725 商品コードバリデートの不整合 #5740
Merged
ref #5725 商品コードバリデートの不整合 #5740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.2 #5740 +/- ##
============================================
+ Coverage 78.83% 78.84% +0.01%
- Complexity 6267 6273 +6
============================================
Files 468 469 +1
Lines 21046 21059 +13
============================================
+ Hits 16592 16605 +13
Misses 4454 4454
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chihiro-adachi
suggested changes
Sep 1, 2022
| @@ -84,6 +84,11 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| ]) | |||
| ->add('code', TextType::class, [ | |||
| 'required' => false, | |||
| 'constraints' => [ | |||
| new Assert\Length([ | |||
| 'max' => 255, | |||
There was a problem hiding this comment.
@nobuhiko
eccube_stext_lenを使っていただけるとありがたいです。
|
@chihiro-adachi 修正しました |
|
ご対応ありがとうございます！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#5725
方針(Policy)
ProductClassType と ProductClassEditType.php で内容が違うのであわせる
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目