voidのメソッドでリターンしているコードを修正 #5692
Merged
voidのメソッドでリターンしているコードを修正 #5692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihiro-adachi
suggested changes
Aug 29, 2022
| @@ -141,11 +141,11 @@ public function execConfig($key, $value = null) | |||
|
|
|||
| public function configureRepository(BaseInfo $BaseInfo) | |||
| { | |||
| return $this->composerApiService->configureRepository($BaseInfo); | |||
| composerApiService->configureRepository($BaseInfo); | |||
There was a problem hiding this comment.
@takeuji
ここでSyntax errorが発生してました。
$this->が抜けてるようです。
| } | ||
|
|
||
| public function foreachRequires($packageName, $version, $callback, $typeFilter = null, $level = 0) | ||
| { | ||
| return $this->composerApiService->foreachRequires($packageName, $version, $callback, $typeFilter, $level); | ||
| composerApiService->foreachRequires($packageName, $version, $callback, $typeFilter, $level); |
|
@chihiro-adachi |
Codecov Report
@@ Coverage Diff @@
## 4.2 #5692 +/- ##
============================================
+ Coverage 78.82% 78.84% +0.01%
- Complexity 6260 6273 +13
============================================
Files 469 469
Lines 21010 21058 +48
============================================
+ Hits 16561 16603 +42
- Misses 4449 4455 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chihiro-adachi
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
voidのメソッドでリターンしているコードを修正しました
ちょうど、#5578で修正済みのものもありました
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目