インストール画面のアラートの修正 #5582
Merged
インストール画面のアラートの修正 #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.2 #5582 +/- ##
=========================================
Coverage 78.84% 78.84%
Complexity 6259 6259
=========================================
Files 469 469
Lines 21001 21001
=========================================
Hits 16559 16559
Misses 4442 4442
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nanasess
requested changes
Aug 23, 2022
| @@ -22,19 +22,19 @@ file that was distributed with this source code. | |||
| {% if app.session.flashBag.has('eccube.install.danger') %} | |||
| {% for message in app.session.flashBag.get('eccube.install.danger') %} | |||
| <div class="row"> | |||
| <div class="alert alert-danger alert-dismissable"> | |||
| <button type="button" class="btn-close" data-bs-dismiss="alert"><span class="alert-close" aria-hidden="true">×</span></button> | |||
| <div class="alert alert-danger alert-dismissable fade show" role="alert"> | |||
There was a problem hiding this comment.
alert-dismissible が正しいと思います
Suggested change
| <div class="alert alert-danger alert-dismissable fade show" role="alert"> | |
| <div class="alert alert-danger alert-dismissible fade show" role="alert"> |
nanasess
approved these changes
Aug 24, 2022
|
@nobuhiko |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
#5581
方針(Policy)
https://getbootstrap.jp/docs/5.0/components/alerts/
書き方が少し変わったらしい
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目