-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change publish_date to include seconds. #5564
Change publish_date to include seconds. #5564
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.2 #5564 +/- ##
============================================
- Coverage 78.84% 78.80% -0.04%
- Complexity 6255 6259 +4
============================================
Files 469 469
Lines 20994 21002 +8
============================================
- Hits 16553 16551 -2
- Misses 4441 4451 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@pineray |
@chihiro-adachi |
@pineray 偶発的にテストがエラーになるやつでしたので、再実行したら解消しました! |
@pineray |
概要(Overview・Refs Issue)
#5544 のエラーを修正
方針(Policy)
原因は、with_seconds のデフォルトが false なのに input のフォーマットが秒を含むものだったため
フォーマットから秒を除くとなるとDatePickerの変更など影響が大きいため、最も簡単に修正できる方法をとった
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目