-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2]admin の bootstrap5対応 #5446
Merged
chihiro-adachi
merged 15 commits into
EC-CUBE:4.2
from
tsumu-tsumu:202200708_admin_bootstrap5
Jul 21, 2022
Merged
[4.2]admin の bootstrap5対応 #5446
chihiro-adachi
merged 15 commits into
EC-CUBE:4.2
from
tsumu-tsumu:202200708_admin_bootstrap5
Jul 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aタグのunderlineをBootstrap4の仕様に変更
もう一度、対象箇所をすべて確認し、修正を加えました。 |
0bc2a5b
to
e924400
Compare
e924400
to
1d04cd9
Compare
@nanasess @tsumu-tsumu |
@chihiro-adachi はい、大丈夫です |
@nanasess @tsumu-tsumu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
- adminのbootstrap5対応です。
bootstrap5に合わせたclass名の変更やbootstrap_4_layout.html.twigの修正、scssを修正しております。
方針(Policy)
src/Eccube/Resource/template/admin/Form/bootstrap_4_layout.html.twig
src/Eccube/Resource/template/admin/Form/bootstrap_4_horizontal_layout.html.twig
11行目に{%- extends 'bootstrap_5_horizontal_layout.html.twig' -%}、{%- extends 'bootstrap_5_layout.html.twig' -%}を追加しており、既存の仕様に影響がない範囲でbootstrap5のマークアップを読み込んでいます。
また日付まわりはDatepickerに修正しました
実装に関する補足(Appendix)
編集ファイルが多かったため、問題ないかご確認お願いいたします。
テスト(Test)
これからすべての箇所をもう一度チェックします。
チェック後、結果をお伝えいたします。
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目