改正商取引法の施行に伴うECカート「最終確認画面」表示項目の変更[#5304]について #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixtureも追加。
チェックはNGの場合、改正商取引法内容を表示しない。 上記の件の更新でUTも更新しました。
nanasess
reviewed
Jun 27, 2022
|
|
||
| class TradeLawController extends AbstractController | ||
| { | ||
| private TradeLawRepository $tradeLawRepository; |
There was a problem hiding this comment.
他の Controller に合わせて protected でお願いします
nanasess
requested changes
Jun 27, 2022
| /** | ||
| * @var TradeLawRepository | ||
| */ | ||
| private TradeLawRepository $tradeLawRepository; |
There was a problem hiding this comment.
他の Controller に合わせて protected でお願いします
There was a problem hiding this comment.
了解いたしました。ShoppingControllerクラスの変数と合わせて変数定義 [例 TradeLawRepository] を削除した方が良いでしょうか？
There was a problem hiding this comment.
Suggested change
| private TradeLawRepository $tradeLawRepository; | |
| protected $tradeLawRepository; |
nanasess
reviewed
Jun 27, 2022
src/Eccube/Controller/Admin/Setting/Shop/TradeLawController.php
Outdated
Show resolved
Hide resolved
- 文字列 `"false"` だと SQLite3 で true と判定されてしまう
|
@sai-gillingham ご対応ありがとうございます！ SQLite3 でテストが落ちていたので修正したのと、フロント側の特定商取引法のページを追加しました |
nanasess
approved these changes
Jun 28, 2022
|
@sai-gillingham |
This was referenced Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
[#5304]
改正商取引法の施行に伴うECカート「最終確認画面」表示項目の変更
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目