Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gulp-sass #5389

Merged
merged 4 commits into from
Jul 21, 2022
Merged

update gulp-sass #5389

merged 4 commits into from
Jul 21, 2022

Conversation

5ym
Copy link

@5ym 5ym commented Jun 14, 2022

最新ではなくても良いのですが、gulp-sassをバージョンアップし、node-sassに依存しないようにしないとalpineでnpm iを実行した際古いnode-sassをインストールするスクリプトにprint "test"のような記述がありpython 3の記法エラーで終了します

最新ではなくても良いのですが、gulp-sassをバージョンアップし、node-sassに依存しないようにしないとalpineでnpm iを実行した際古いnode-sassをインストールするスクリプトにprint "test"のような記述がありpython 3の記法エラーで終了します
@chihiro-adachi chihiro-adachi added this to the 4.1.x milestone Jun 15, 2022
@chihiro-adachi
Copy link
Contributor

@5ym
ありがとうございます!
ちょうどこの事象にぶつかってて困ってたところでした。大変助かります。

5ym pushed a commit to 5ym/ec-cube that referenced this pull request Jun 16, 2022
@5ym 5ym mentioned this pull request Jun 16, 2022
@5ym 5ym closed this Jun 20, 2022
@5ym 5ym deleted the patch-1 branch June 20, 2022 16:28
@5ym 5ym restored the patch-1 branch June 20, 2022 16:28
@5ym 5ym reopened this Jun 20, 2022
@5ym
Copy link
Author

5ym commented Jun 24, 2022

@chihiro-adachi 本家に追従したので再度テストの承認をお願いします!

@codecov-commenter
Copy link

Codecov Report

Merging #5389 (b8b3966) into 4.1 (bfeb2c9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                4.1    #5389      +/-   ##
============================================
- Coverage     68.58%   68.57%   -0.01%     
  Complexity     6162     6162              
============================================
  Files           463      463              
  Lines         25306    25306              
============================================
- Hits          17356    17354       -2     
- Misses         7950     7952       +2     
Flag Coverage Δ
E2E 57.95% <ø> (ø)
Unit 76.13% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Eccube/Doctrine/Common/CsvDataFixtures/Loader.php 72.50% <0.00%> (-5.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfeb2c9...b8b3966. Read the comment docs.

@chihiro-adachi chihiro-adachi merged commit 781b44d into EC-CUBE:4.1 Jul 21, 2022
@chihiro-adachi
Copy link
Contributor

@5ym
ありがとうございます。マージしました。

@5ym 5ym deleted the patch-1 branch January 13, 2023 04:22
@Yangsin Yangsin modified the milestones: 4.1.3, 4.2.0 Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants