[OWASP ZAP] 商品管理>カテゴリ管理 CSVダウンロードを追加 #5337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.1 #5337 +/- ##
============================================
+ Coverage 68.55% 68.59% +0.03%
Complexity 6159 6159
============================================
Files 463 463
Lines 25279 25279
============================================
+ Hits 17331 17340 +9
+ Misses 7948 7939 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nanasess
requested changes
Mar 30, 2022
| expect(message.responseHeader).toContain('HTTP/1.1 200 OK'); | ||
| }); | ||
|
|
||
| const ｃｓｖExportURL = `${PlaywrightConfig.use.baseURL}/${ECCUBE_ADMIN_ROUTE}/product/category/export`; |
There was a problem hiding this comment.
@nanasess
ご指摘ありがとうございます。
修正しました。
| test.describe('プロダクト用雛形テンプレートのダウンロード時のテストを実行します[GET] @attack', () => { | ||
| let scanId: number; | ||
| test('プロダクト用雛形テンプレートのダウンロード時のアクティブスキャンを実行します', async () => { | ||
| scanId = await zapClient.activeScanAsUser(ｃｓｖExportURL, 2, 55, false, null, 'GET', message.requestBody); |
There was a problem hiding this comment.
GET の場合は requestBody 不要かと思います
There was a problem hiding this comment.
@nanasess
ご指摘ありがとうございます。
削除させていただきました。
nanasess
approved these changes
Apr 8, 2022
|
@carkn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
OWASP ZAP 商品管理>カテゴリ管理 CSVダウンロードを追加
方針(Policy)
実装に関する補足(Appendix)
テスト（Test)
手元の環境で実行できていることを確認しています。
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目