-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OWASP ZAP] 商品管理 規格管理 新規作成 #5334
[OWASP ZAP] 商品管理 規格管理 新規作成 #5334
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.1 #5334 +/- ##
=========================================
Coverage 68.55% 68.56%
Complexity 6159 6159
=========================================
Files 463 463
Lines 25279 25279
=========================================
+ Hits 17331 17333 +2
+ Misses 7948 7946 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -47,6 +48,10 @@ jobs: | |||
if: matrix.group == 'test/admin/content_layout_delete.test.ts' | |||
working-directory: zap/selenium/ci/TypeScript | |||
run: git am patches/0001-DeleteLayout.patch | |||
- name: Apply patch to new_product_class_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
規格の新規登録時は重複チェックしないため、パッチを当てなくてもテストできそうですが、いかがでしょうか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nanasess
ご指摘ありがとうございます。
パッチ適用を取り下げさせていただきました。
概要(Overview・Refs Issue)
Owasp ZAP 自動化: 商品管理 > 規格管理 新規追加
についてのテストを追加
方針(Policy)
実装に関する補足(Appendix)
実際に新規追加が行われないようにパッチを作成しています。
テスト(Test)
手元の環境で実行できることを確認しています。
相談(Discussion)
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目