Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2Eテスト改善 EA03_Product #5159

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

matsuoshi
Copy link
Contributor

概要(Overview・Refs Issue)

E2Eテスト改善 EA03_Product
管理画面 商品管理ページの E2E テストの追加・修正です

該当するテストケース:
https://github.com/EC-CUBE/eccube-specification/blob/4.1/IntegrationTest/EA03_Product_%E7%B5%90%E5%90%88%E8%A9%A6%E9%A8%93%E9%A0%85%E7%9B%AE%E6%9B%B8.md

同時にテストケースも一部修正しています、PRは以下となります
EC-CUBE/eccube-specification#73

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@codecov-commenter
Copy link

Codecov Report

Merging #5159 (0dd6aea) into 4.1 (5691c3b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              4.1    #5159   +/-   ##
=======================================
  Coverage   68.23%   68.24%           
=======================================
  Files         455      455           
  Lines       24930    24930           
=======================================
+ Hits        17012    17014    +2     
+ Misses       7918     7916    -2     
Flag Coverage Δ
tests 68.24% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/Controller/Admin/Product/CsvImportController.php 55.75% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5691c3b...0dd6aea. Read the comment docs.

@matsuoshi matsuoshi changed the title [WIP] E2Eテスト改善 EA03_Product E2Eテスト改善 EA03_Product Sep 14, 2021
@matsuoshi matsuoshi marked this pull request as ready for review September 14, 2021 05:28
@kiy0taka kiy0taka merged commit 10473e5 into EC-CUBE:4.1 Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants