レビュー用PR_2023_03_24に関しての修正 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiy0taka
suggested changes
Mar 27, 2023
This was referenced Mar 29, 2023
Merged
Merged
Merged
Merged
sai-gillingham
added a commit
to sai-gillingham/TwoFactorAuthCustomerSms42
that referenced
this pull request
Mar 29, 2023
※ TwoFactorAuthCustomer42プラグインのトークンの長さ設定とSMS有効期限設定を利用するようになる EC-CUBE/TwoFactorAuthCustomer42#42
kiy0taka
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3 (comment)
について、他の->findOneBy([〇〇]) === null箇所の代わりにcount関数を利用するように更新しました。
#3 (comment)
について、本会員時の本人認証のワンタイムトークン長をservices.ymlで変更出来るようになりました。
#3 (comment)
について、getFromPhonenumber/setFromPhonenumber関数名をgetFromPhoneNumber / setFromPhoneNumber になりました。
#3 (comment)
について、スロットリングパラメータはルーティング名と合わせました。