Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typos in tests3 README file. #357

Merged
merged 2 commits into from
Jan 14, 2025
Merged

fixed typos in tests3 README file. #357

merged 2 commits into from
Jan 14, 2025

Conversation

TonyB9000
Copy link
Collaborator

Issue resolution

  • Closes #<ISSUE_NUMBER_HERE>

Select one: This pull request is...

  • a document typo fix: increment nothing. Keep it a deep, dark secret.
  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

@forsyth2
Copy link
Collaborator

@TonyB9000 Thanks, I'll add a commit to fix the pre-commit checks and then merge

@TonyB9000
Copy link
Collaborator Author

@forsyth2 Your instructions worked fine:

(base) [ac.bartoletti1@chrlogin1 zstash]$ git checkout non-block-testing
Already on 'non-block-testing'
Your branch is up to date with 'origin/non-block-testing'.
(base) [ac.bartoletti1@chrlogin1 zstash]$ git branch -m non-block-testing-fix
(base) [ac.bartoletti1@chrlogin1 zstash]$ git push origin non-block-testing-fix
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote:
remote: Create a pull request for 'non-block-testing-fix' on GitHub by visiting:
remote:      https://github.com/E3SM-Project/zstash/pull/new/non-block-testing-fix

Curious there's now a build error . . . (pre-commit hooks)...

@forsyth2
Copy link
Collaborator

Curious there's now a build error . . . (pre-commit hooks)...

That's actually carried over from #355 -- https://github.com/E3SM-Project/zstash/actions/runs/12677945696, the pre-commit checks were failing when the PR was merged.

@forsyth2
Copy link
Collaborator

Well now I'm getting on git fetch upstream for some reason, so have to debug that first...

git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@TonyB9000
Copy link
Collaborator Author

@forsyth2 Related? I just made small changes to my datasm repo (locally) and tried to push them to remote. I get a "500" internal server error. (Usually, I would get prompted for my git key-pass). Perhaps the acme1 update is again at issue.

@forsyth2
Copy link
Collaborator

Perhaps the acme1 update is again at issue.

No, I don't think so. I run into this issue on multiple repos, on multiple machines. I also tagged you in my question on Slack

@forsyth2
Copy link
Collaborator

@TonyB9000 Ok, GitHub's command line fetching is working again. I added the pre-commit error fixes. Per discussion on #355, I'll do a merge commit here since these are two distinct pieces of work.

@forsyth2 forsyth2 merged commit 68c023b into main Jan 14, 2025
3 checks passed
@forsyth2 forsyth2 deleted the non-block-testing-fix branch January 17, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants