Skip to content

Commit

Permalink
Make setup.py consistent with conda recipe (#250)
Browse files Browse the repository at this point in the history
* Bump `isort` version to fix poetry error

* Update GH Actions actions versions

* Make `conda/meta.yaml` and `setup.py` consistent

Inconsistencies in `setup.py` are causing `pip check` to fail
on the conda package.
  • Loading branch information
xylar authored Feb 2, 2023
1 parent 7624232 commit 054cf5f
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 20 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ jobs:
timeout-minutes: 2
steps:
- name: Checkout Code Repository
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Set up Python 3.9
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.9

# Run all pre-commit hooks on all the files.
# Getting only staged files can be tricky in case a new PR is opened
# since the action is run on a branch in detached head state
- name: Install and Run Pre-commit
uses: pre-commit/action@v2.0.0
uses: pre-commit/action@v3.0.0

build:
runs-on: ubuntu-latest
Expand All @@ -33,10 +33,10 @@ jobs:
shell: bash -l {0}
timeout-minutes: 20
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.9

Expand All @@ -58,18 +58,18 @@ jobs:
shell: bash -l {0}
timeout-minutes: 5
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.9

- name: Cache pip
uses: actions/cache@v2
uses: actions/cache@v3
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ jobs:
shell: bash -l {0}
timeout-minutes: 5
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v2
uses: actions/setup-python@v4
with:
python-version: 3.9

- name: Cache pip
uses: actions/cache@v2
uses: actions/cache@v3
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
Expand Down Expand Up @@ -86,10 +86,10 @@ jobs:
run:
shell: bash -l {0}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Cache Conda
uses: actions/cache@v2
uses: actions/cache@v3
env:
# Increase this value to reset cache if conda/zstash_dev.yml has not changed in the workflow
CACHE_NUMBER: 0
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ repos:
hooks:
- id: black

- repo: https://github.com/timothycrosley/isort
rev: 5.7.0
- repo: https://github.com/PyCQA/isort
rev: 5.12.0
hooks:
- id: isort

Expand Down
4 changes: 2 additions & 2 deletions conda/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ requirements:

run:
- python >=3.6
- fair-research-login >=0.2.6,<0.3.0
- globus-sdk >=3.0.0,<4.0.0
- six
- globus-sdk >=2
- fair-research-login

test:
imports:
Expand Down
7 changes: 4 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@
author_email="forsyth2@llnl.gov, golaz1@llnl.gov, shaheen2@llnl.gov",
description="Long term HPSS archiving software for E3SM",
packages=find_packages(include=["zstash", "zstash.*"]),
python_requires=">=3.6",
install_requires=[
"six==1.16.0",
"globus-sdk<4.0.0>=3.0.0",
"fair-research-login==0.2.6",
"fair-research-login>=0.2.6,<0.3.0",
"globus-sdk>=3.0.0,<4.0.0",
"six",
],
entry_points={"console_scripts": ["zstash=zstash.main:main"]},
)

0 comments on commit 054cf5f

Please sign in to comment.