Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Fixes #265

Merged
merged 1 commit into from
Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion zppy/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,10 @@ def main(): # noqa: C901
partition = config["default"]["partition"]
if partition not in ["haswell", "knl"]:
raise ValueError(
f'Expected Cori parition to be "haswell" or '
f'Expected Cori partition to be "haswell" or '
f'"knl" but got: {partition}'
)
# This will be the [default] environment_commands
environment_commands = (
f"source {unified_base}/load_latest_e3sm_unified_cori-{partition}.sh"
)
Expand Down
2 changes: 2 additions & 0 deletions zppy/bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ def __init__(self, c):
self.account: str = c["account"]
self.dry_run: bool = c["dry_run"]
self.debug: bool = c["debug"]
self.environment_commands: str = c["environment_commands"]
self.script_dir: str = c["scriptDir"]
self.nodes: int = c["nodes"]
self.partition: str = c["partition"]
Expand Down Expand Up @@ -47,6 +48,7 @@ def render(self, config):
c["machine"] = config["default"]["machine"]
c["account"] = config["default"]["account"]
c["debug"] = self.debug
c["environment_commands"] = self.environment_commands
c["scriptDir"] = self.script_dir
c["prefix"] = self.bundle_name
c["nodes"] = self.nodes
Expand Down
2 changes: 1 addition & 1 deletion zppy/ilamb_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def ilamb_run(config, scriptDir, existing_bundles):
# --- List of ilamb_run tasks ---
tasks = getTasks(config, "ilamb_run")
if len(tasks) == 0:
return []
return existing_bundles

# --- Generate and submit ilamb_run scripts ---
dependencies = []
Expand Down