-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colormap limits for spherical viz #278
Conversation
TestingAll omega-supported tests have been run on chrys with intel, openmpi |
@andrewdnolan I assume that you accidentally left out the colormap over/under settings when you made the switch to mosaic. Let me know if I'm mistaken. |
@cbegeman Thanks for catching that! Yes, in the switch from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the omega
sub-module update belongs here, but I'll leave that up to you and @xylar to hash out.
In terms of the changes to polaris/viz/spherical.py
, that all look good to me. Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm fine with the testing you've done, @cbegeman.
I think it's fine to combine these things even though they're not obviously related. We can basically update the Omega submodule whenever it's convenient at this point. At some point, we'll want to be more careful about it but that's a bit off still. |
Colormap over/under settings from config files were not being used for spherical viz. Omega submodule is also updated.
Checklist
Testing
comment in the PR documents testing used to verify the changes