Convert H2OLNZ units to ppm by volume #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangq
approved these changes
Oct 25, 2024
|
Thank you @tangq |
19 tasks
tomvothecoder
added a commit
that referenced
this pull request
Jan 10, 2025
tomvothecoder
added a commit
that referenced
this pull request
Jan 15, 2025
**Bug Fixes:** - Fixed incorrect logic in `cf_units.Unit` that replaced `genutil.udunits`, which previously caused incorrect results. **Performance Improvements:** - Improved subsetting logic by performing a time slice before loading time series datasets into memory, enhancing performance by reducing the size of the datasets - Optimized variable derivation by subsetting and loading datasets into memory with `.load(scheduler="sync")` first, as the `convert_units()` function requires in-memory access for `cf_units.Unit` operations -- affected `MERRA2` datasets - Addressed an issue with single-point time dimensions in climatology datasets (e.g., OMI-MLS). xCDAT now squeezes the time dimension to remove time coordinates and bounds before loading the dataset, avoiding errors like "Non-integer years and months are ambiguous and not currently supported." -- affected `OMI-MLS` datasets - Update `_get_slice_from_time_bounds()` to load time bounds into memory if they already exist using `.load(scheduler="sync")` to avoid hanging -- affected `streamflow` datasets - Add missed unit conversion for `H2OLNZ` via #874 to address large differences - Related code: https://github.com/E3SM-Project/e3sm_diags/blame/ca41b0e5d913610c88410928951f1ed11c75663f/e3sm_diags/driver/zonal_mean_2d_driver.py#L166-L171 **Testing:** - Performed regression testing with v2 and v3 data. Results check-out, but a closer look will be done after v3.0.0rc1 release. --------- Co-authored-by: tomvothecoder <tomvothecoder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolve comments #868 (comment)
Checklist
If applicable: