Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.8 #844

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

altheaden
Copy link
Contributor

Description

Python 3.8 is no longer supported by conda-forge, so I removed references to it from setup.py.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xylar
Copy link
Contributor

xylar commented Sep 4, 2024

@chengzhuzhang, @tomvothecoder and @forsyth2, I've tasked @altheaden with looking around at various E3SM python packages for python 3.8. It was dropped recently on conda-forge so we probably can't safely support it anymore:
conda-forge/conda-forge-pinning-feedstock#5013

@xylar
Copy link
Contributor

xylar commented Sep 4, 2024

@tomvothecoder, can you check if failing CI is something we did here or if it's a pre-existing problem?

@xylar
Copy link
Contributor

xylar commented Sep 4, 2024

It looked like it was maybe just a timeout to the LCRC server. I'll try again.

@chengzhuzhang
Copy link
Contributor

@xylar @altheaden thanks for working on this!

Copy link
Collaborator

@tomvothecoder tomvothecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @altheaden. Looks good to me!

@chengzhuzhang chengzhuzhang merged commit 1278873 into E3SM-Project:main Sep 4, 2024
4 checks passed
@altheaden altheaden deleted the drop-python-3.8 branch September 4, 2024 17:51
@xylar
Copy link
Contributor

xylar commented Sep 4, 2024

Thanks @tomvothecoder and @chengzhuzhang!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants