Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update input data path; nco invocation in pre-processing #593

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

chengzhuzhang
Copy link
Contributor

Update input data path to a more permanent location;
Update NCO invocation for recent NCO API changes.

Copy link
Contributor Author

@chengzhuzhang chengzhuzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@forsyth2 I left some comments, just in case zppy needs the similar updates.

@@ -10,7 +10,7 @@ source /global/common/software/e3sm/anaconda_envs/load_latest_e3sm_unified_cori-
start="0051"
end="0060"
caseid="20210528.v2rc3e.piControl.ne30pg2_EC30to60E2r2.chrysalis"
drc_in=/global/cscratch1/sd/forsyth/e3sm_unified_test_zppy/${caseid}/archive/atm/hist
drc_in=/global/cfs/cdirs/e3smdata/zppy_complete_run_nersc_output/${caseid}/archive/atm/hist
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model data for testing has moved to a more permanent location.

@@ -59,17 +59,17 @@ drc_rgr=${dir_out_diurnal_climo}/rgr
drc_out=${dir_out_diurnal_climo}/native
echo ${drc_in}

cd ${drc_in};eval ls ${caseid}.${atm_name}.h4.*{${start}..${end}}*.nc | ncclimo -P ${atm_name} --clm_md=hfc --caseid=${caseid}.${atm_name}.h4 -v PRECT --ypf=1 --yr_srt=${start} --yr_end=${end} --drc_out=${drc_out} -O $drc_rgr --map=${map_file}
cd ${drc_in};eval ls ${caseid}.${atm_name}.h4.*{${start}..${end}}*.nc | ncclimo -P ${atm_name} --clm_md=hfc --caseid=${caseid}.${atm_name}.h4 -v PRECT --yr_srt=${start} --yr_end=${end} --drc_out=${drc_out} -O $drc_rgr --map=${map_file}
Copy link
Contributor Author

@chengzhuzhang chengzhuzhang May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --ypf option now is an implicit way of triggering timeseries even when --clm_md=hfc is specified, because --ypf (years per file) makes no sense for a climatology

##
echo "Generating per-variable monthly time-series."
drc_rgr=${dir_out_ts}/rgr
drc_out=${dir_out_ts}/native

echo "Variables for Streamflow"
cd ${drc_in_river};eval ls ${caseid}*mosart.h0.*{${start}..${end}}*.nc | ncclimo --caseid=${caseid} --var_xtr=areatotal2 -v RIVER_DISCHARGE_OVER_LAND_LIQ --yr_srt=$start --yr_end=$end --drc_out=${drc_rgr}
cd ${drc_in_river};eval ls ${caseid}*mosart.h0.*{${start}..${end}}*.nc | ncclimo --caseid=${caseid} --var_xtr=areatotal2 -v RIVER_DISCHARGE_OVER_LAND_LIQ --yr_srt=$start --yr_end=$end --drc_out=${drc_rgr} --split
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --split option now is the explicit way of triggering timeseries. Without it, this line invokes climatology mode.

#
echo "Variables for supporting diags using monthly time series as input(ENSO, QBO, etc.)"
cd ${drc_in};eval ls ${caseid}.${atm_name}.h0.*{${start}..${end}}*.nc | ncclimo -P ${atm_name} --caseid=${caseid} --var=U,CLDHGH,CLDLOW,CLDMED,CLDTOT,FLNS,FLUT,FSNS,FSNT,FSNTOA,LANDFRAC,LHFLX,LWCF,OCNFRAC,PRECC,PRECL,PSL,QFLX,SHFLX,SWCF,T,TAUX,TAUY,TREFHT,TS --yr_srt=$start --yr_end=$end --drc_out=${drc_out} -O $drc_rgr --map=${map_file}
cd ${drc_in};eval ls ${caseid}.${atm_name}.h0.*{${start}..${end}}*.nc | ncclimo -P ${atm_name} --caseid=${caseid} --var=U,CLDHGH,CLDLOW,CLDMED,CLDTOT,FLNS,FLUT,FSNS,FSNT,FSNTOA,LANDFRAC,LHFLX,LWCF,OCNFRAC,PRECC,PRECL,PSL,QFLX,SHFLX,SWCF,T,TAUX,TAUY,TREFHT,TS --yr_srt=$start --yr_end=$end --drc_out=${drc_out} -O $drc_rgr --map=${map_file} --split
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment for --split as above.

@chengzhuzhang chengzhuzhang marked this pull request as ready for review May 27, 2022 17:35
@chengzhuzhang chengzhuzhang requested a review from forsyth2 May 27, 2022 17:35
@chengzhuzhang chengzhuzhang merged commit 680589e into master Jun 3, 2022
@forsyth2
Copy link
Collaborator

forsyth2 commented Jun 9, 2022

I left some comments, just in case zppy needs the similar updates.

I created E3SM-Project/zppy#254 to look into that.

@chengzhuzhang chengzhuzhang deleted the update_preprocessing branch June 9, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants