Time Stepping design doc #94
Conversation
There was a problem hiding this comment.
@mark-petersen, I think this looks good. I just have one comment about adding a temporal convergence study to the testing section.
|
Please review when you get a chance: @sbrus89 @mwarusz @hyungyukang I would like to make any revisions and merge this week. |
|
Looks good. I have a comment regarding rhs functions that depend explicitly on time. I remember that in MPAS-O the RK4 scheme had some issues with that. Can we add treating this properly as a required or desired capability ? The description of the forward/backward scheme also doesn't treat this case, but it is needed for the manufactured solution test. |
There was a problem hiding this comment.
@mark-petersen , Overall, all look great. I left a comment on adding other time stepping methods. We can add more later together after merging.
Co-authored-by: Hyun-Gyu Kang <47987430+hyungyukang@users.noreply.github.com>
The time stepping design document for Omega-0. During this review, the documentation is available here for convenient viewing.
Checklist