Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata design doc to table of contents #20

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

xylar
Copy link

@xylar xylar commented Jun 13, 2023

Also, a little clean up.

Checklist

  • Documentation:
    • Design document has been generated and added to the docs
    • Documentation has been built locally and changes look as expected

@xylar xylar added the documentation Improvements or additions to documentation label Jun 13, 2023
@xylar xylar requested a review from philipwjones June 13, 2023 08:03
@xylar
Copy link
Author

xylar commented Jun 13, 2023

@philipwjones, in the process of looking at #19 (including building the docs locally), I noticed this design doc missing from the table of contents. I overlooked this in my review of #13.

Copy link

@philipwjones philipwjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching - both the internal formatting and missing index entry. Looks fine by inspection.

@xylar
Copy link
Author

xylar commented Jun 13, 2023

Okay, feel free to merge whenever you're ready. I don't have integrator right.

@philipwjones philipwjones merged commit e3310b4 into E3SM-Project:develop Jun 13, 2023
@xylar xylar deleted the clean-up-docs branch June 22, 2023 15:59
amametjanov pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants