IO Design documents #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Looks like I didn't rebase correctly...will fix. |
d24b971 to
29b4c43
Compare
xylar
approved these changes
Jun 2, 2023
Comment on lines
94
to
96
| exists. A minimum set of options should include over-writing | ||
| (replacing) the file, appending to the existing file, or exiting | ||
| with an error message. |
There was a problem hiding this comment.
It might be good to also have a way to indicate whether to replace existing time slices in a file or skip over them. The former isn't the same as replacing the whole file, and also isn't the same as appending (which I think is the same as the latter -- skipping time slices that exist and only writing new ones).
There was a problem hiding this comment.
Added the requirement to over-write portions of a file in latest version. We'll decide names for those options during implementation.
Comment on lines
+195
to
+198
| Note that there is a stdlib iostreams so our use of IOStreams runs | ||
| the risk of inadvertent conflict. Use of both the Omega namespace and | ||
| the capitalized IOStreams will be used to distinguish the two. |
mark-petersen
approved these changes
Jun 13, 2023
includes an IOStreams capability and a lower level IO interface
added the IO designs to the main doc index modified requirement to include overwriting portions of a file
29b4c43 to
f6a0124
Compare
grnydawn
pushed a commit
to grnydawn/Omega
that referenced
this pull request
Jun 23, 2023
added initial IO design docs for Omega - includes an IOStreams capability and a lower level IO interface - added the IO designs to the main doc index - modified requirement to include overwriting portions of a file, in response to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two design documents for an IOStreams capability and an underlying IO layer that interfaces with Scorpio