Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cori_atmnbfb testing to use new e3sm_simple environment #6

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

jhkennedy
Copy link
Contributor

@jhkennedy jhkennedy commented Aug 4, 2019

The climate reproducibility tests being run in the cori_atmnbfb test suite are being refactored in [Forthcoming CIME PR] to use the EVV conda package, which is installed in the new e3sm_simple conda environment. This updates the cori_atmnbfb jenkins job to use e3sm_simple.

I also updated the README a bit to use more of the available code markdown syntax.


Still TODO

This is marked as a WIP because these things are required first:

Note: The current version of the PGN test being run in the cori_atmnbfb test suite requires the Scikit Learn conda package but the refactored PGN will not need it (same things accomplished in numpy). So:

  • The current PGN test will break in the e3sm_simple environment because of the missing scikit-learn package
  • The refactored PGN and TSC test will break in the python/2.7-anaconda-5.2 environment currently used on cori-knl because of the missing evv4esm package.

Need to unload the python module that comes from `cork-knl_setup.sh`
then activate the `e3sm_simple` environment
@jhkennedy jhkennedy requested a review from jgfouca August 4, 2019 14:23
@xylar
Copy link
Contributor

xylar commented Aug 4, 2019

I'm assuming my input isn't needed on this but let me know.

jgfouca added a commit to E3SM-Project/E3SM that referenced this pull request Aug 16, 2019
Update climate reproducibility tests (MVK, PGN, TSC)

Updates the MVK, PGN, and TSC climate reproducibility tests to all be
production ready. They will all generate an appropriate baseline, run
the comparison and produce a pass-fail result, and through EVV provide
a portable website with in-depth test details to analyze why these
tests pass/fail. An example of the output websites produced for both a
failing case and a bit-for-bit case can be seen here:

https://livvkit.github.io/evv4esm/index.html

This will allow the e3sm_atm_nbfb test suite, under E3SM_Custom_Tests
on the test dashboard, to pass and be operationally effective for
climate reproducibility testing (tests' motivation discussed here ).

These tests add external python dependencies to CIME (but only when
one of these tests are run) and as such require a python environment
with some of the scientific python stack. An e3sm_simple environment
has been deployed to cori in the same manner as the e3sm_unified
environment and will provide the necessary dependencies; see
E3SM-Project/e3sm-unified#53. Additionally, the jenkins job which runs
these test on cori-knl will be updated to use the e3sm_simple
environment through E3SM-Project/E3SM_test_scripts#6.

New baselines will need to be generated for these tests.

[B4B]

* origin/jhkennedy/cime/climate-repo-update:
  Add MVK test to e3sm_atm_nbfb test suite
  Refactor climate reproducibility ests for e3sm_simple env and EVV release
  Remove unneeded requirements.txt b/c of conda package
  Finished PGN refactor
  Partial refactor of PGN system test
  Minor updates for MVK system tests
  PEP8 and string formatting updates for PNG test
  Update MVK for E3SM atmosphere component directory name changes
jgfouca added a commit to E3SM-Project/E3SM that referenced this pull request Aug 16, 2019
Update climate reproducibility tests (MVK, PGN, TSC)

Updates the MVK, PGN, and TSC climate reproducibility tests to all be
production ready. They will all generate an appropriate baseline, run
the comparison and produce a pass-fail result, and through EVV provide
a portable website with in-depth test details to analyze why these
tests pass/fail. An example of the output websites produced for both a
failing case and a bit-for-bit case can be seen here:

https://livvkit.github.io/evv4esm/index.html

This will allow the e3sm_atm_nbfb test suite, under E3SM_Custom_Tests
on the test dashboard, to pass and be operationally effective for
climate reproducibility testing (tests' motivation discussed here ).

These tests add external python dependencies to CIME (but only when
one of these tests are run) and as such require a python environment
with some of the scientific python stack. An e3sm_simple environment
has been deployed to cori in the same manner as the e3sm_unified
environment and will provide the necessary dependencies; see
E3SM-Project/e3sm-unified#53. Additionally, the jenkins job which runs
these test on cori-knl will be updated to use the e3sm_simple
environment through E3SM-Project/E3SM_test_scripts#6.

New baselines will need to be generated for these tests.

[B4B]

* origin/jhkennedy/cime/climate-repo-update:
  Add MVK test to e3sm_atm_nbfb test suite
  Refactor climate reproducibility ests for e3sm_simple env and EVV release
  Remove unneeded requirements.txt b/c of conda package
  Finished PGN refactor
  Partial refactor of PGN system test
  Minor updates for MVK system tests
  PEP8 and string formatting updates for PNG test
  Update MVK for E3SM atmosphere component directory name changes
@jhkennedy jhkennedy changed the title [WIP] Update cori_atmnbfb testing to use new e3sm_simple environment Update cori_atmnbfb testing to use new e3sm_simple environment Aug 16, 2019
@jhkennedy
Copy link
Contributor Author

@jgfouca I think this one's ready now

@jgfouca jgfouca merged commit bc57c57 into E3SM-Project:master Aug 16, 2019
jgfouca added a commit to ESMCI/cime that referenced this pull request Aug 20, 2019
Update climate reproducibility tests (MVK, PGN, TSC)

Updates the MVK, PGN, and TSC climate reproducibility tests to all be
production ready. They will all generate an appropriate baseline, run
the comparison and produce a pass-fail result, and through EVV provide
a portable website with in-depth test details to analyze why these
tests pass/fail. An example of the output websites produced for both a
failing case and a bit-for-bit case can be seen here:

https://livvkit.github.io/evv4esm/index.html

This will allow the e3sm_atm_nbfb test suite, under E3SM_Custom_Tests
on the test dashboard, to pass and be operationally effective for
climate reproducibility testing (tests' motivation discussed here ).

These tests add external python dependencies to CIME (but only when
one of these tests are run) and as such require a python environment
with some of the scientific python stack. An e3sm_simple environment
has been deployed to cori in the same manner as the e3sm_unified
environment and will provide the necessary dependencies; see
E3SM-Project/e3sm-unified#53. Additionally, the jenkins job which runs
these test on cori-knl will be updated to use the e3sm_simple
environment through E3SM-Project/E3SM_test_scripts#6.

New baselines will need to be generated for these tests.

[B4B]

* origin/jhkennedy/cime/climate-repo-update:
  Add MVK test to e3sm_atm_nbfb test suite
  Refactor climate reproducibility ests for e3sm_simple env and EVV release
  Remove unneeded requirements.txt b/c of conda package
  Finished PGN refactor
  Partial refactor of PGN system test
  Minor updates for MVK system tests
  PEP8 and string formatting updates for PNG test
  Update MVK for E3SM atmosphere component directory name changes
@jhkennedy jhkennedy deleted the update-atmnbfb branch September 3, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants