Fix uninitialized variable delt_save in mosart's RtmMod.F90 #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two minor modifications suggested:
|
This PR fixes an uninitialized variable in mosart's RtmMod.F90 file. Note that similar bug was fixed in a file with the same name in rtm component. Fixes #902 [BFB]
48b49d4 to
6281bf4
Compare
Two minor modifications suggested: 1. No need to keep the commented out line RtmMod.F90#L1429. So let's delete it. 2. The blame feature of git can tell which developer last edited a line. So, no need to add !BSINGH- on RtmMod.F90#L103
|
Thanks @bishtgautam . I have rebased and implemented your suggestions in a new commit. |
|
Merged in next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an uninitialized variable in mosart's RtmMod.F90 file.
Note that similar bug was fixed in a file with the same name in rtm
component.
Fixes #902
[BFB]