Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column-integrated water flux output #82

Closed
wants to merge 1 commit into from

Conversation

tangq
Copy link
Contributor

@tangq tangq commented Jan 21, 2015

Add vertically integrated water flux output
* TUQ: Total zonal water vapor flux
* TVQ: Total meridional water vapor flux

[BFB]

Add vertically integrated water flux output
	* TUQ: Total zonal water vapor flux
	* TVQ: Total meridional water vapor flux

[BFB]
@rljacob
Copy link
Member

rljacob commented Jan 22, 2015

Is there a JIRA issue associated with this?

@tangq
Copy link
Contributor Author

tangq commented Jan 22, 2015

Hi Robert,

This change is suggested by Peter Caldwell (cc'd). Maybe there's a JIRA issue under the coupled task (Peter?)

Qi

From: Robert Jacob <notifications@github.commailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, January 21, 2015 4:23 PM
To: ACME-Climate/ACME <ACME@noreply.github.commailto:ACME@noreply.github.com>
Cc: "Tang, Qi" <tang30@llnl.govmailto:tang30@llnl.gov>
Subject: Re: [ACME] Add column-integrated water flux output (#82)

Is there a JIRA issue associated with this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/82#issuecomment-70949573.

@susburrows
Copy link
Contributor

Hi Qi Tang,

I also have a couple of questions:

  • have you run the developer test suite?
  • It looks like a lot of the changes in the commit are actually just white space / carriage returns and not actual file modifications that you intentionally made. Could you please fix this and make a new PR?

@susburrows
Copy link
Contributor

You can probably fix it by doing:
$git config --global core.autocrlf false
$git config --global core.safecrlf false

And then doing a clean clone of the repository, then applying your changes.

@tangq
Copy link
Contributor Author

tangq commented Jan 22, 2015

A clean one is created.

@tangq tangq closed this Jan 22, 2015
@tangq tangq deleted the tangq/cam/H2O_transport branch January 22, 2015 00:43
@tangq
Copy link
Contributor Author

tangq commented Jan 22, 2015

Hi Rob,

Nope, there’s no JIRA task because I didn’t know this capability was a possibility until yesterday, when I found out that it was not only possible but already implemented. This functionality will be very useful for diagnostics, so the cost/benefit ratio is great. Feel free to make a JIRA task for merging this to the master if that makes your life easier.

Thanks,
Peter

From: , Qi <tang30@llnl.govmailto:tang30@llnl.gov>
Date: Wednesday, January 21, 2015 at 4:31 PM
To: ACME-Climate/ACME <reply@reply.github.commailto:reply@reply.github.com>, ACME-Climate/ACME <ACME@noreply.github.commailto:ACME@noreply.github.com>
Cc: Peter Caldwell <caldwell19@llnl.govmailto:caldwell19@llnl.gov>
Subject: Re: [ACME] Add column-integrated water flux output (#82)

Hi Robert,

This change is suggested by Peter Caldwell (cc'd). Maybe there's a JIRA issue under the coupled task (Peter?)

Qi

From: Robert Jacob <notifications@github.commailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, January 21, 2015 4:23 PM
To: ACME-Climate/ACME <ACME@noreply.github.commailto:ACME@noreply.github.com>
Cc: "Tang, Qi" <tang30@llnl.govmailto:tang30@llnl.gov>
Subject: Re: [ACME] Add column-integrated water flux output (#82)

Is there a JIRA issue associated with this?


Reply to this email directly or view it on GitHubhttps://github.com//pull/82#issuecomment-70949573.

jgfouca pushed a commit that referenced this pull request Jun 25, 2019
sbrus89 pushed a commit to sbrus89/E3SM that referenced this pull request Jul 19, 2024
matthewhoffman added a commit that referenced this pull request Aug 14, 2024
…evelop

This PR follows #82, which added subglacial hydrology (SGH) quantities to the
global stats analysis member, by adding SGH quantities to the regional stats
analysis member.

This PR also address a bug introduced in #82 where the calculation of
groundingLineFlux and groundingLineMigrationFlux were moved within an
if config_SGH then condition. The bug prevents groundingLineFlux and
groundingLineMigrationFlux from being calculated by global stats unless
the SGH model is turned on, despite these quantities applying to simulations
where SGH is not used.

* MALI-Dev/andrewdnolan/mali/hydro_regional_stats:
  Fix registry typo Matt caught in review.
  Remove `regionVertexMasks` from registry to minimize file size.
  Apply suggestions from code review
  Use `regionEdgeMask` to calculate SGH regional stats defined on edges.
  Deallocate `regionalSumFlotationFraction`.
  Add missing `regionCellMasks` call from SGH regional stats terms
  Add grounded ice mask to `externalWaterInput` term
  Move reduction of `fluxAcrossGroundingLine` outside SGH condition.
  Add support for subglacial hydro quantities in regional stats.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants