-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column-integrated water flux output #82
Conversation
Add vertically integrated water flux output * TUQ: Total zonal water vapor flux * TVQ: Total meridional water vapor flux [BFB]
Is there a JIRA issue associated with this? |
Hi Robert, This change is suggested by Peter Caldwell (cc'd). Maybe there's a JIRA issue under the coupled task (Peter?) Qi From: Robert Jacob <notifications@github.commailto:notifications@github.com> Is there a JIRA issue associated with this? — |
Hi Qi Tang, I also have a couple of questions:
|
You can probably fix it by doing: And then doing a clean clone of the repository, then applying your changes. |
A clean one is created. |
Hi Rob, Nope, there’s no JIRA task because I didn’t know this capability was a possibility until yesterday, when I found out that it was not only possible but already implemented. This functionality will be very useful for diagnostics, so the cost/benefit ratio is great. Feel free to make a JIRA task for merging this to the master if that makes your life easier. Thanks, From: , Qi <tang30@llnl.govmailto:tang30@llnl.gov> Hi Robert, This change is suggested by Peter Caldwell (cc'd). Maybe there's a JIRA issue under the coupled task (Peter?) Qi From: Robert Jacob <notifications@github.commailto:notifications@github.com> Is there a JIRA issue associated with this? — |
Tendency Design Document
…evelop This PR follows #82, which added subglacial hydrology (SGH) quantities to the global stats analysis member, by adding SGH quantities to the regional stats analysis member. This PR also address a bug introduced in #82 where the calculation of groundingLineFlux and groundingLineMigrationFlux were moved within an if config_SGH then condition. The bug prevents groundingLineFlux and groundingLineMigrationFlux from being calculated by global stats unless the SGH model is turned on, despite these quantities applying to simulations where SGH is not used. * MALI-Dev/andrewdnolan/mali/hydro_regional_stats: Fix registry typo Matt caught in review. Remove `regionVertexMasks` from registry to minimize file size. Apply suggestions from code review Use `regionEdgeMask` to calculate SGH regional stats defined on edges. Deallocate `regionalSumFlotationFraction`. Add missing `regionCellMasks` call from SGH regional stats terms Add grounded ice mask to `externalWaterInput` term Move reduction of `fluxAcrossGroundingLine` outside SGH condition. Add support for subglacial hydro quantities in regional stats.
Add vertically integrated water flux output
* TUQ: Total zonal water vapor flux
* TVQ: Total meridional water vapor flux
[BFB]