Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix iso_c_binding in Okubo-Weiss analysis member #7064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix iso_c_binding in Okubo-Weiss analysis member #7064

wants to merge 1 commit into from

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Feb 27, 2025

Newer versions of Gnu are showing errors without this change.

Fixes #7060
Fixes #6688

@xylar xylar added mpas-ocean bug fix PR MPAS-Ocean standalone Issues and features for standalone MPAS-Ocean code that dont impact E3SM. labels Feb 27, 2025
@xylar xylar requested a review from mark-petersen February 27, 2025 07:52
@xylar xylar requested a review from ndkeen February 27, 2025 07:53
@xylar
Copy link
Contributor Author

xylar commented Feb 27, 2025

@ndkeen, can you verify that this fixes #6688?

@xylar
Copy link
Contributor Author

xylar commented Feb 27, 2025

Standalone MPAS-Ocean Testing

I build MPAS-Ocean with craygnu on Frontier. Without this change, I got the error reported in #7060. With the change, I was able to build the code and run the pr test suite.

I am not aware of any tests (Polaris, Compass or E3SM) that currently activate the okubo-weiss analysis member and I do not feel it is in the scope of this bug fix to construct one. But if anyone feels strongly otherwise, I will look into it.

@xylar xylar mentioned this pull request Feb 27, 2025
Draft
74 tasks
@ndkeen
Copy link
Contributor

ndkeen commented Feb 27, 2025

Yes, I just verified the following test can build with this branch. That is, with gcc-native 13.2 module on NERSC machine.
ERS_Ld5.T62_oQU120.CMPASO-NYF.alvarez_gnu

@xylar
Copy link
Contributor Author

xylar commented Feb 27, 2025

Thanks for checking @ndkeen! It will be nice to get this issue fixed.

@xylar
Copy link
Contributor Author

xylar commented Feb 27, 2025

@mark-petersen, can you take a look when you have time? Do you know how to test this AM in an easy way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkeen ndkeen ndkeen approved these changes

@mark-petersen mark-petersen Awaiting requested review from mark-petersen

Assignees

@jonbob jonbob

Labels
bug fix PR MPAS-Ocean standalone Issues and features for standalone MPAS-Ocean code that dont impact E3SM. mpas-ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standalone MPAS-Ocean can't be built with craygnu on Frontier Build errors with gcc version 13.2
3 participants
@xylar @ndkeen @jonbob