-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wave Momentum Coupling #6943
base: master
Are you sure you want to change the base?
Wave Momentum Coupling #6943
Conversation
i.e. wav_ocn_coup = 'none', 'one', or 'two' for no coupling, one way coupling (ocn to wav), or full two way coupling
…nvil Pe layout for B case with waves
For wave-enabled compsets, is this PR climate changing even with the feature is off? |
The results are BFB for compsets when waves are turned off. For wave-enabled compsets, by default, this feature will be ON. This feature does change the results from the current status of wave coupling, however, the current status of wave coupling in E3SM is not complete, therefore we do not yet have an estimate of the fully-coupled-climate with waves. Therefore, I would not say this PR is "climate-changing" since we have no baseline of "climate with waves" against which to compare. This PR is working towards that goal of obtaining a "climate with waves". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The COARE algorithm needs a thorough review, especially these lines
E3SM/share/util/shr_flux_mod.F90
Lines 528 to 529 in 9676973
wind0 = max(sqrt((ubot(n) - us(n))**2 + (vbot(n) - vs(n))**2), 0.01_r8) | |
vmag = max(seq_flux_atmocn_minwind, wind0) |
E3SM/share/util/shr_flux_mod.F90
Lines 338 to 343 in 9676973
wind0 = max(sqrt((ubot(n) - us(n))**2 + (vbot(n) - vs(n))**2), 0.01_r8) | |
vmag = wind0 | |
if (present(ugust)) then | |
vmag = sqrt(vmag**2 + ugust(n)**2) | |
end if | |
vmag = max(seq_flux_atmocn_minwind, vmag) |
We attempted to use COARE in v2 with significant problems. Gustiness may have been the cause, now corrected for (ocn_surface_flux_scheme .eq. 0
but not (ocn_surface_flux_scheme .eq. 1
. So as part of this PR, we also need a simulation illustrating that E3SM PI is not significantly different, and conserves, with COARE switched on without waves.
In addition, it needs to be explicitly shown that there is no sea level rise with waves switched on, so the B-case linked above needs to be stopped, and a new one included with the correct land initial conditions.
This PR introduces a new feature to E3SMv3: Wave Momentum coupling between WW3-MPAO-EAM. This is a "stealth" feature since wave-enabled compsets are not part of standard production runs. This PR is BFB in non-wave enabled compsets, however, in wave-enabled compsets, this PR will impact the results. This PR is working towards developing a fully coupled climate "with waves" - the "LRW" configuration. Note: This feature will be used in some of the Blue-Tip simulations.
[FCC] for wave-enabled compsets when turned on
This new Feature is fully documented in a Design Doc:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4902158337/Design+document+for+Wave-Momentum+Coupling
The 30+ yr PI control run with MPAS_Analysis and E3SM_Diags is documented in the simulation page:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4901208068/Wave+Momentum+Coupling+E3SMv3+PI+Control+Run
Note: This PR must be merged AFTER #6885