Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wave Momentum Coupling #6943

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

erinethomas
Copy link
Contributor

@erinethomas erinethomas commented Jan 24, 2025

This PR introduces a new feature to E3SMv3: Wave Momentum coupling between WW3-MPAO-EAM. This is a "stealth" feature since wave-enabled compsets are not part of standard production runs. This PR is BFB in non-wave enabled compsets, however, in wave-enabled compsets, this PR will impact the results. This PR is working towards developing a fully coupled climate "with waves" - the "LRW" configuration. Note: This feature will be used in some of the Blue-Tip simulations.

[FCC] for wave-enabled compsets when turned on


This new Feature is fully documented in a Design Doc:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4902158337/Design+document+for+Wave-Momentum+Coupling

The 30+ yr PI control run with MPAS_Analysis and E3SM_Diags is documented in the simulation page:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/4901208068/Wave+Momentum+Coupling+E3SMv3+PI+Control+Run

Note: This PR must be merged AFTER #6885

erinethomas and others added 30 commits January 9, 2025 17:22
i.e. wav_ocn_coup = 'none', 'one', or 'two' for no coupling,
     one way coupling (ocn to wav), or full two way coupling
@erinethomas erinethomas requested a review from sbrus89 January 24, 2025 21:32
@erinethomas erinethomas requested a review from vanroekel January 24, 2025 21:33
@erinethomas erinethomas added BFB PR leaves answers BFB CC PR is climate changing labels Jan 24, 2025
@rljacob rljacob added Stealth PR has feature which, if turned on, could change climate. fka FCC and removed BFB PR leaves answers BFB labels Jan 27, 2025
@rljacob
Copy link
Member

rljacob commented Jan 27, 2025

For wave-enabled compsets, is this PR climate changing even with the feature is off?

@erinethomas erinethomas removed the CC PR is climate changing label Jan 27, 2025
@erinethomas
Copy link
Contributor Author

erinethomas commented Jan 27, 2025

The results are BFB for compsets when waves are turned off. For wave-enabled compsets, by default, this feature will be ON. This feature does change the results from the current status of wave coupling, however, the current status of wave coupling in E3SM is not complete, therefore we do not yet have an estimate of the fully-coupled-climate with waves. Therefore, I would not say this PR is "climate-changing" since we have no baseline of "climate with waves" against which to compare. This PR is working towards that goal of obtaining a "climate with waves".
Based on this logic, I have removed the CC tag (it seems to be a somewhat unique case- and I am not sure which tags apply)

Copy link
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The COARE algorithm needs a thorough review, especially these lines

wind0 = max(sqrt((ubot(n) - us(n))**2 + (vbot(n) - vs(n))**2), 0.01_r8)
vmag = max(seq_flux_atmocn_minwind, wind0)
which should be analogous to
wind0 = max(sqrt((ubot(n) - us(n))**2 + (vbot(n) - vs(n))**2), 0.01_r8)
vmag = wind0
if (present(ugust)) then
vmag = sqrt(vmag**2 + ugust(n)**2)
end if
vmag = max(seq_flux_atmocn_minwind, vmag)
but is not.

We attempted to use COARE in v2 with significant problems. Gustiness may have been the cause, now corrected for (ocn_surface_flux_scheme .eq. 0 but not (ocn_surface_flux_scheme .eq. 1. So as part of this PR, we also need a simulation illustrating that E3SM PI is not significantly different, and conserves, with COARE switched on without waves.

In addition, it needs to be explicitly shown that there is no sea level rise with waves switched on, so the B-case linked above needs to be stopped, and a new one included with the correct land initial conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coupled Model Coupler eam mpas-ocean Stealth PR has feature which, if turned on, could change climate. fka FCC Wave
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants