Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on additional output for SORRMv3 mesh #6757

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

darincomeau
Copy link
Member

Turns on the ocean conservation analysis member and ocean eddy analysis member for the SOwISC12to30E3r3 mesh.

This allows plotting of mass flux anomaly due to land ice fluxes and EKE in MPAS-Analysis.

[BFB]

@darincomeau
Copy link
Member Author

Tested

SMS.ne30pg2_r05_SOwISC12to30E3r3.CRYO1850.chrysalis_intel
confirmed mpaso_in settings turned on here, and

SMS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel
confirmed mpaso_in settings changed here for SOwISC12to30E3r3 remained default off.

@proteanplanet
Copy link
Contributor

Can you provide an estimate of the added computational overhead from this change?

@darincomeau
Copy link
Member Author

darincomeau commented Nov 19, 2024

@proteanplanet turning on the ocean eddy analysis member is in the noise/machine variability as far as I can tell.

Example PACE with ocean eddy analysis on:
https://pace.ornl.gov/exp-details/201662, 8.13 SYPD

Example PACE with ocean eddy analysis off:
https://pace.ornl.gov/exp-details/199419, 8.13 SYPD

I don't have an estimate for the computational overhead of the ocean conservation analysis member here, since we always run with it on (and need it on). When I turned it on for v2 Cryo meshes, I found minimal impact in one-year B-case tests.

Copy link
Contributor

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darincomeau! I agree that this is what we want. Let me know if you'd like me to do any additional testing.

@darincomeau
Copy link
Member Author

@proteanplanet I ran a pair of small one month ne30pg2_r05_SOwISC12to30E3r3.CRYO1850 tests to estimate performance cost:

Baseline (additional analysis remains off): 1.85 SYPD
This PR (additional analysis on): 1.80 SYPD

So that's an estimated 2-3% overhead for the additional analysis members here.

Copy link
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Additional computation costs are minimal and necessary.

jonbob added a commit that referenced this pull request Dec 2, 2024
Turn on additional output for SORRMv3 mesh

Turns on the ocean conservation analysis member and ocean eddy analysis
member for the SOwISC12to30E3r3 mesh. This allows plotting of mass flux
anomaly due to land ice fluxes and EKE in MPAS-Analysis.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Dec 2, 2024

Passes:

  • ERP_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-pioroot1

merged to next

@jonbob jonbob merged commit 6d2aea7 into E3SM-Project:master Dec 3, 2024
12 checks passed
@jonbob
Copy link
Contributor

jonbob commented Dec 3, 2024

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants