For pm-cpu, remove libfabric work-around of setting FI_CXI_RX_MATCH_MODE=software
#6703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
what kind of testing have you done? |
rljacob
approved these changes
Oct 28, 2024
FI_CXI_RX_MATCH_MODE-softwareFI_CXI_RX_MATCH_MODE=software
|
In general, I've done quite a bit of testing with this over the years -- with various cases looking for performance changes (there were not any). I'm sure I've run integration before and I can run again, but don't expect any surprises. |
|
merged to next |
|
Tests all green as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had been using
FI_CXI_RX_MATCH_MODE=softwareon pm-cpu to avoid some issues when Perlmutter was young.There was no measurable performance difference, so did not change this setting.
Now let's try removing this and letting it use the default which is
FI_CXI_RX_MATCH_MODE=hybrid.[BFB]