Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating CRYO compsets to v3 ELM settings #6625

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Updating CRYO compsets to v3 ELM settings #6625

merged 3 commits into from
Sep 25, 2024

Conversation

darincomeau
Copy link
Member

@darincomeau darincomeau commented Sep 19, 2024 •
edited by jonbob
Loading

Updates the ELM settings in the following compsets to the v3 settings in #6108.

CRYO1850
CRYO1850-DISMF
CRYO1850-4xCO2
CRYO1950
CRYO1950-DISMF
CRYO20TR
CRYOSSP370
CRYOSSP585

Adds CRYO1850-1pctCO2 and CRYOSSP245 compsets matching the WCYCL counterparts.

[NML] only for CRYO* compsets
[non-BFB] only for CRYO* compsets.

@darincomeau darincomeau requested a review from wlin7 September 19, 2024 01:04
@rljacob rljacob added this to the v3.0.1 milestone Sep 19, 2024
@darincomeau
Copy link
Member Author

darincomeau commented Sep 19, 2024 •
edited
Loading

Passes

SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-4xCO2.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-1pctCO2.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYO20TR.chrysalis_intel (after doing ./xmlchange RUN_STARTDATE="1850-01-01")
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP245.chrysalis_intel
ERS.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF.chrysalis_intel

I've left the following compsets unchanged since there are no plans to use them for v3. However it might be best to change these as well for consistency.
CRYO1950
CRYO1950-DISMF
CRYOSSP370
CRYOSSP585

Updated to include these.

@darincomeau darincomeau changed the title Updating CRYO1850* compsets to v3 ELM settings Updating CRYO compsets to v3 ELM settings Sep 19, 2024
@darincomeau
Copy link
Member Author

Flagging @stephenprice and @proteanplanet as Polar leads (I don't think you need to review but you're welcome to).

@rljacob
Copy link
Member

rljacob commented Sep 19, 2024 •
edited
Loading

For those other compsets (CRYO1950, etc.), if you're not going to use them, just remove them.

@stephenprice
Copy link
Contributor

Looks good to me Darin. Thanks.

@proteanplanet
Copy link
Contributor

@darincomeau Thanks for doing this. I wonder if we still need CRYO1950, CRYO1950-DISMF, and CRYOSSP370 up our sleeve in case we want to run a comparison, however short, with V2?

@stephenprice
Copy link
Contributor

I think we should keep the 1950 support for a bit yet.

@darincomeau
Copy link
Member Author

I agree Andrew, Steve. I've made the change for all CRYO compsets.

Additionally tested and passes:

SMS.ne30pg2_IcoswISC30E3r5.CRYO1950.chrysalis_intel
SMS.ne30pg2_IcoswISC30E3r5.CRYO1950-DISMF.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP370.chrysalis_intel
SMS.ne30pg2_r05_IcoswISC30E3r5.CRYOSSP585.chrysalis_intel

@rljacob
Copy link
Member

rljacob commented Sep 20, 2024

@wlin7 please review.

wlin7
wlin7 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@wlin7 wlin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look good, consistently with the changes to the 'physics' for elm. The addtional compsets are all good.

@jonbob jonbob added non-BFB PR makes roundoff changes to answers. Coupled Model labels Sep 24, 2024
jonbob added a commit that referenced this pull request Sep 24, 2024
@jonbob
Merge branch 'darincomeau/scripts/update-v3-cryo-compsets' into next …
6095d1a 
…(PR #6625)

Updating CRYO compsets to v3 ELM settings

Updates the ELM settings in the following compsets to the v3 settings in
PR #6108:
* CRYO1850
* CRYO1850-DISMF
* CRYO1850-4xCO2
* CRYO1950
* CRYO1950-DISMF
* CRYO20TR
* CRYOSSP370
* CRYOSSP585
Adds following compsets matching the WCYCL counterparts:
* CRYO1850-1pctCO2
* CRYOSSP245

[non-BFB] only for CRYO* compsets
@jonbob
Copy link
Contributor

jonbob commented Sep 24, 2024

Passes e3sm_cryo_developer on chrysalis, merged to next

@jonbob jonbob added the NML label Sep 25, 2024
@jonbob jonbob merged commit ae51494 into E3SM-Project:master Sep 25, 2024
8 of 9 checks passed
@jonbob
Copy link
Contributor

jonbob commented Sep 25, 2024

merged to master and expected DIFFs and NML DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlin7 wlin7 wlin7 approved these changes

Assignees

@jonbob jonbob

Labels
compset Coupled Model Land NML non-BFB PR makes roundoff changes to answers.
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
6 participants
@darincomeau @rljacob @stephenprice @proteanplanet @jonbob @wlin7