Bug fix for N balance error due to spval value for land use simulation #6618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the land use data is on, at the begining of every year, the model may crash with N balance error due to including spval value in N leaching flux update. This update fixes this error by keeping those spval values away. The fix should be BFB for simulations do not involve land use data.
|
qzhu-lbl
approved these changes
Sep 18, 2024
|
Hi @jinyuntang , what kind of land use you referred to? Does the standard v3 coupled historical configuration belong to this type? One of the historical simulation member (WCYCL20TR compset) is also suffering from the |
acme-y9s
approved these changes
Sep 18, 2024
|
@bishtgautam please merge this to next today. |
bishtgautam
added a commit
that referenced
this pull request
Sep 18, 2024
When the land use data is on, at the begining of every year, the model may crash with N balance error due to including spval value in N leaching flux update. This update fixes this error by keeping those spval values away from the N balance. Fixes #6604 [BFB]
bpbond
approved these changes
Sep 18, 2024
|
@bishtgautam you can merge this to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the land use data is on, at the begining of every year, the model
may crash with N balance error due to including spval value in N leaching
flux update. This update fixes this error by keeping those spval values away
from the N balance.
Fixes #6604
[BFB]