Switch global ocean in init mode to E3SM shared constants #6481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge also migrates the computation of the coriolis parameter to using E3SM shared constants. The unused constants module imports are removed from several init mode utilities to ensure that they don't use constants that are inconsistent with E3SM's versions.
|
See E3SM-Ocean-Discussion#96 for some relevant discussion/ |
|
@proteanplanet and @mark-petersen, if you could approve this based on the revierw you already did in E3SM-Ocean-Discussion#96, that would be great! |
proteanplanet
approved these changes
Jun 25, 2024
mark-petersen
approved these changes
Jun 25, 2024
jonbob
added a commit
that referenced
this pull request
Jun 27, 2024
…6481) Switch global ocean in init mode to E3SM shared constants The unused constants module imports are removed from several init mode utilities to ensure that they don't use constants that are inconsistent with E3SM's versions. This merge also migrates the computation of the Coriolis parameter to using E3SM shared constants. Also made local symlinks to the shared constants and kinds file for convenience in building using MPAS-Ocean's not-very-sophisticated build system. [BFB] -- mpas-ocean standalone only
|
passes:
merged to next |
|
merged to master |
|
Thanks @jonbob, @mark-petersen and @proteanplanet! |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jul 3, 2024
This merge updates the E3SM-Project submodule from [31f771c](https://github.com/E3SM-Project/E3SM/tree/31f771c) to [c7d7998](https://github.com/E3SM-Project/E3SM/tree/c7d7998). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6472 - [ ] (ocn) E3SM-Project/E3SM#6471 - [ ] (ocn) E3SM-Project/E3SM#6481
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jul 4, 2024
This merge updates the E3SM-Project submodule from [31f771c](https://github.com/E3SM-Project/E3SM/tree/31f771c) to [c7d7998](https://github.com/E3SM-Project/E3SM/tree/c7d7998). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6472 - [ ] (ocn) E3SM-Project/E3SM#6471 - [ ] (ocn) E3SM-Project/E3SM#6481
3 tasks
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jul 4, 2024
This merge updates the E3SM-Project submodule from [31f771c](https://github.com/E3SM-Project/E3SM/tree/31f771c) to [c7d7998](https://github.com/E3SM-Project/E3SM/tree/c7d7998). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6472 - [ ] (ocn) E3SM-Project/E3SM#6471 - [ ] (ocn) E3SM-Project/E3SM#6481
xylar
added a commit
to xylar/compass
that referenced
this pull request
Jul 4, 2024
This merge updates the E3SM-Project submodule from [31f771c](https://github.com/E3SM-Project/E3SM/tree/31f771c) to [c7d7998](https://github.com/E3SM-Project/E3SM/tree/c7d7998). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#6472 - [ ] (ocn) E3SM-Project/E3SM#6471 - [ ] (ocn) E3SM-Project/E3SM#6481
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge also migrates the computation of the Coriolis parameter to using E3SM shared constants.
The unused constants module imports are removed from several init mode utilities to ensure that they don't use constants that are inconsistent with E3SM's versions.
I have made local symlinks to the shared constants and kinds file for convenience in building using MPAS-Ocean's not-very-sophisticated build system.