Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds LULC for ELM at r025 grid #6477

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Adds LULC for ELM at r025 grid #6477

merged 1 commit into from
Sep 5, 2024

Conversation

bishtgautam
Copy link
Contributor

@bishtgautam bishtgautam commented Jun 17, 2024 •
edited
Loading

A LULC file for 1850-2015 at r025 is added.

[BFB]

@bishtgautam bishtgautam requested a review from tangq June 17, 2024 19:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6477/
on branch gh-pages at 2024-09-03 19:18 UTC

@rljacob
Copy link
Member

rljacob commented Jul 25, 2024

@tangq please review.

1 similar comment
@rljacob
Copy link
Member

rljacob commented Aug 15, 2024

@tangq please review.

@rljacob rljacob added this to the v3.0.1 milestone Aug 15, 2024
rljacob
rljacob reviewed Aug 16, 2024
View reviewed changes
components/elm/bld/namelist_files/use_cases/20thC_CMIP6_transient.xml Outdated
@@ -38,6 +38,7 @@
<finidat hgrid="ne30np4" mask="oEC60to30v3">lnd/clm2/initdata_map/20180316.DECKv1b_A1.ne30_oEC.edison.clm2.r.1980-01-01-00000.8575c3f_c20190904.nc</finidat>

<flanduse_timeseries hgrid="r05">lnd/clm2/surfdata_map/landuse.timeseries_0.5x0.5_hist_simyr1850-2015_c240308.nc</flanduse_timeseries>
<flanduse_timeseries hgrid="r025" sim_year_range="1850-2000" use_crop=".false." >lnd/clm2/surfdata_map/landuse.timeseries_0.25x0.25_hist_simyr1850-2015_c240125.nc</flanduse_timeseries>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file name suggests its 1850-2015 but "sim_year_range" is 1850-2000. Is one of those wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rljacob, Great catch. I will fix the range.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I edited the commit and forced pushed the branch.

@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/narrm-lulc branch from 0066369 to 366b470 Compare August 22, 2024 20:59
@bishtgautam bishtgautam requested a review from rljacob August 22, 2024 21:00
@bishtgautam bishtgautam changed the title Adds LULC for NARRM Adds LULC for ELM at r025 grid Aug 22, 2024
tangq
tangq approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@tangq tangq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. The NARRM test is successful with this fix.

wlin7
wlin7 reviewed Aug 28, 2024
View reviewed changes
components/elm/bld/namelist_files/use_cases/20thC_CMIP6_transient.xml Outdated
@@ -38,6 +38,7 @@
<finidat hgrid="ne30np4" mask="oEC60to30v3">lnd/clm2/initdata_map/20180316.DECKv1b_A1.ne30_oEC.edison.clm2.r.1980-01-01-00000.8575c3f_c20190904.nc</finidat>

<flanduse_timeseries hgrid="r05">lnd/clm2/surfdata_map/landuse.timeseries_0.5x0.5_hist_simyr1850-2015_c240308.nc</flanduse_timeseries>
<flanduse_timeseries hgrid="r025" sim_year_range="1850-2015" use_crop=".false." >lnd/clm2/surfdata_map/landuse.timeseries_0.25x0.25_hist_simyr1850-2015_c240125.nc</flanduse_timeseries>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bishtgautam , it appears needing to remove sim_year_range="1850-2015" attribute above for F20TR.ne120pg2_r025_RRSwISC6to18E3r5 configuration to correctly pick up this file. Otherwise, build-namelist would complain no default flanduse_timeseries is set.

The test case has STARTDATE=1985-01-01. Not sure if it matters. Since 20TR (and this 20thC use case) is meant for the year range of 1850-2015. There should be no confusion taking away that attribute.

@peterdschwartz
Copy link
Contributor

@bishtgautam see wlin7's review comment above

@bishtgautam
Adds LULC for NARRM
9034faa 
A LULC file for 1850-2000 at r025 is added.

[BFB]
@bishtgautam bishtgautam force-pushed the bishtgautam/lnd/narrm-lulc branch from 366b470 to 9034faa Compare September 3, 2024 17:56
@bishtgautam
Copy link
Contributor Author

@peterdschwartz, I forced pushed my branch to remove the incorrect commit.

@rljacob
Copy link
Member

rljacob commented Sep 4, 2024

If this is ready, please start merging it.

@peterdschwartz
Copy link
Contributor

Sure, if no one has anything else to add, then I'll merge it this afternoon

peterdschwartz added a commit that referenced this pull request Sep 4, 2024
@peterdschwartz
Merge branch 'bishtgautam/lnd/narrm-lulc' into next (PR #6477)
29e9bcb 
A LULC file for 1850-2015 at r025 is added.

[BFB]
@peterdschwartz
Copy link
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit 9d67d78 into master Sep 5, 2024
21 checks passed
@peterdschwartz peterdschwartz deleted the bishtgautam/lnd/narrm-lulc branch September 5, 2024 16:38
@peterdschwartz
Copy link
Contributor

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlin7 wlin7 wlin7 left review comments

@rljacob rljacob rljacob approved these changes

@tangq tangq tangq approved these changes

Assignees

@peterdschwartz peterdschwartz

Labels
Land
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@bishtgautam @rljacob @peterdschwartz @wlin7 @tangq