Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move extrasnowlayers test to e3sm_landice_developer suite #6399

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented May 6, 2024

Since PR #6226 redefined the IGELM compset, the SMS.ne30_oECv3_gis.IGELM_MLI.elm-extrasnowlayers test has been failing. This moves that test from the e3sm_ocnice_extra_coverage suite to the e3sm_landice_developer suite, which is only run on platform/compiler combinations that support active MALI.

[BFB] for all current E3SM tests

@jonbob jonbob added mpas-albany-landice BFB PR leaves answers BFB Testing Anything related to unit/system tests labels May 6, 2024
@jonbob jonbob requested a review from stephenprice May 6, 2024 19:00
@jonbob jonbob self-assigned this May 6, 2024
Copy link

github-actions bot commented May 6, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6399/
on branch gh-pages at 2024-05-06 19:03 UTC

@jonbob
Copy link
Contributor Author

jonbob commented May 6, 2024

passed the e3sm_landice_developer suite with the new test on chrysalis with gnu

@stephenprice
Copy link
Contributor

Thanks @jonbob. This looks good to me, but I wonder if we need to also add these two lines ...

config_velocity_solver = 'none'
config_thickness_advection = 'none'

... to the nl file associated w/ this test:

/components/elm/cime_config/testdefs/testmods_dirs/elm/extrasnowlayers/user_nl_mali

I think this test probably assumes no MALI solve and previous defaults were such that this was the case by default.

Flagging @chloewhicker, @matthewhoffman, and @trhille so that they can also have a quick look and comment. I'll also add @chloewhicker as a reviewer since this is her test.

@chloewhicker
Copy link
Contributor

Good catch Steve! Yes, for use_extrasnowlayers I always run with those two lines in my user_nl_mali

@rljacob
Copy link
Member

rljacob commented May 30, 2024

@stephenprice please approve

@rljacob
Copy link
Member

rljacob commented Jun 13, 2024

@stephenprice please approve.

Copy link
Contributor

@stephenprice stephenprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. I did not see it until just now. Approved!

jonbob added a commit that referenced this pull request Jun 20, 2024
Move extrasnowlayers test to e3sm_landice_developer suite

Since PR #6226 redefined the IGELM compset, the
SMS.ne30_oECv3_gis.IGELM_MLI.elm-extrasnowlayers test has been failing.
This moves that test from the e3sm_ocnice_extra_coverage suite to the
e3sm_landice_developer suite, which is only run on platform/compiler
combinations that support active MALI.

[BFB] for all current E3SM tests
@jonbob
Copy link
Contributor Author

jonbob commented Jun 20, 2024

Tested by running the e3sm_landice_developer suite on chrysalis with gnu. The new test passes, though there are issues with the gnu compiler that impact other tests

merged to next

@jonbob jonbob merged commit 752f281 into master Jun 21, 2024
21 checks passed
@jonbob jonbob deleted the jonbob/landice/cleanup-igelm-tests branch June 21, 2024 17:11
@jonbob
Copy link
Contributor Author

jonbob commented Jun 21, 2024

merged to master and new test is blessed on both chrysalis and pm-cpu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-albany-landice Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants