-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move extrasnowlayers test to e3sm_landice_developer suite #6399
Conversation
|
passed the e3sm_landice_developer suite with the new test on chrysalis with gnu |
Thanks @jonbob. This looks good to me, but I wonder if we need to also add these two lines ...
... to the nl file associated w/ this test:
I think this test probably assumes no MALI solve and previous defaults were such that this was the case by default. Flagging @chloewhicker, @matthewhoffman, and @trhille so that they can also have a quick look and comment. I'll also add @chloewhicker as a reviewer since this is her test. |
Good catch Steve! Yes, for |
@stephenprice please approve |
@stephenprice please approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this. I did not see it until just now. Approved!
Move extrasnowlayers test to e3sm_landice_developer suite Since PR #6226 redefined the IGELM compset, the SMS.ne30_oECv3_gis.IGELM_MLI.elm-extrasnowlayers test has been failing. This moves that test from the e3sm_ocnice_extra_coverage suite to the e3sm_landice_developer suite, which is only run on platform/compiler combinations that support active MALI. [BFB] for all current E3SM tests
Tested by running the e3sm_landice_developer suite on chrysalis with gnu. The new test passes, though there are issues with the gnu compiler that impact other tests merged to next |
merged to master and new test is blessed on both chrysalis and pm-cpu |
Since PR #6226 redefined the IGELM compset, the SMS.ne30_oECv3_gis.IGELM_MLI.elm-extrasnowlayers test has been failing. This moves that test from the e3sm_ocnice_extra_coverage suite to the e3sm_landice_developer suite, which is only run on platform/compiler combinations that support active MALI.
[BFB] for all current E3SM tests