Removes few ELM fields that were added by default #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glacier-related fields are only added when `create_glacier_mec_landunit = .true.`. Fixes #6365
|
@rljacob While the answers will not change, the tests using this branch will report that the ELM restart file is missing a few fields. Should this PR be marked as BFB or non-BFB? |
|
restart files are not compared in testing. just history. |
|
I have updated the label and comment. |
|
@golaz please try this out. |
rljacob
approved these changes
May 9, 2024
|
since @rljacob went ahead and approved, that I'll go ahead with the merge today unless there are any objections. |
peterdschwartz
added a commit
that referenced
this pull request
May 16, 2024
The glacier-related fields should only be added when create_glacier_mec_landunit = .true.. Fixes #6365
|
Merged to next. Expect DIFFs due to FIELD LIST for any tests that compare elm.h0 files. |
|
Merged to master. hopefully got all the DIFFs |
|
@wlin7 will double-check that this fixes restart issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glacier-related fields should only be added when
create_glacier_mec_landunit = .true..Fixes #6365