Add DOCN to moab driver #6249
Merged
Add DOCN to moab driver #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rljacob
reviewed
Feb 21, 2024
jgfouca
requested changes
Mar 27, 2024
| @@ -1,2 +1,3 @@ | |||
| string(APPEND CMAKE_C_FLAGS_RELEASE " -O2") | |||
| string(APPEND CMAKE_Fortran_FLAGS_RELEASE " -O2") | |||
| set(MOAB_PATH "/nfs/gce/projects/climate/software/moab/devel/mpich-4.0/gcc-11.1.0") | |||
There was a problem hiding this comment.
These MOAB_PATH values need to be in config_machines using the MOAB_ROOT environment var, using the established pattern (checking if it's already set etc).
There was a problem hiding this comment.
I think I have to wait until you merge #6308 because its needs the changes to the MPAS framework cmake. I'll rebase this after you merge 6308.
There was a problem hiding this comment.
I've rebased this branch and removed all the MOAB_PATHs
| @@ -10,3 +10,4 @@ set(MPIFC "ftn") | |||
| set(SCC "gcc") | |||
| set(SCXX "g++") | |||
| set(SFC "gfortran") | |||
| set(MOAB_PATH "/global/cfs/cdirs/e3sm/software/moab/gnu") | |||
| @@ -29,3 +29,4 @@ string(APPEND CMAKE_Fortran_FLAGS " -fp-model=consistent -fimf-use-svml") | |||
| string(APPEND CMAKE_Fortran_FLAGS_RELEASE " -g -traceback") | |||
| string(APPEND CMAKE_Fortran_FLAGS " -DHAVE_ERF_INTRINSICS") | |||
| string(APPEND CMAKE_CXX_FLAGS " -fp-model=consistent") | |||
| set(MOAB_PATH "/global/cfs/cdirs/e3sm/software/moab/intel") | |||
…ities (for OCN) since they are culled - and creates a discontinuous ID space
…ransfer information. This commit also has several other fixes for the data ocean model to work correctly during setup/init
…ignGlobalIDs that only exists in a specific MOAB branch
also, we have an extra ocean instance used for flux calculations
code should work with mct driver
… can use comm graph to communicate with MOAB decomposition
…tion correctly. So_t and area/frac values are propagating correctly for example
use NO_CULLING for data ocean fractions ofrac are copied now from atmosphere frac to ocean, then projected to atm ? global ids are retrieved from gsmap now instead of domain for flux ao calculations domain ocean is not init properly for data ocean maybe the correct change is to initialize it properly on ocean data side it crashes now in phys atm, something is still missing
these are local in the module no need to retrieve them every time
aream needs to be copied for atm, and projected for ocean, when samegrid_ao is true
it would lead to a seq_map_map call to be left out for MCT driver workflow
read ocean domain file on coupler side only pass the file name with infodata, similar to land and rof mesh files use frac, area, mask from mct, not from domain file use only one instance of ocean on component side, corresponding to mct grid need to define GLOBAL_ID tag to ocean instances, after reading the mesh, otherwise the tag is not retrieved from the instance at restart
component_mod depends on cplcomp_exchange_mod
we use this for computing the L2 norm of the errors either on component side or coupler side current intel compiler on chrysalis complains about a not initialized variable It is used in a MPI reduce sum
this is a strange build issue
Remove moab includes which should not be needed for building.
intel still has runtime issues related to -lm undefined symbol: __libm_sincos_e7 mct driver is fine, even though it is linked using -lm could be hdf5 dependency
also, only on the master task
896afef to
b170f68
Compare
Remove MOAB_PATH from perlmutter and anlgce
|
@jgfouca the MOAB_PATH's were removed and this was rebased on to the head of master. F-cases still build and run on perlmutter with moab. |
jgfouca
approved these changes
Mar 28, 2024
rljacob
added a commit
that referenced
this pull request
Mar 29, 2024
Add support for the MOAB coupler in data-ocean. This allows running F-cases that have ocean as the only data model and use MPAS-Seaice with the moab coupler. On the component data side, instance a new imoab application whose degrees of freedom are aligned with the regular domain decomposition from the data model. More changes were needed on the coupler side, because previous coupled cases did not have samegrid_ao flag true. Also, changes in the intel compiler or bios on chrysalis uncovered other needs about initialization of mpi_reduce variables. (mpi_reduce is needed for comparisons between mct and moab fields, in debug/verification mode) Also add MOAB libs to perlmutter. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the MOAB coupler in data-ocean.
This allows running F-cases that have ocean as the only data model and use MPAS-Seaice with the moab coupler.
On the component data side, instance a new imoab application whose degrees of freedom are aligned with the regular
domain decomposition from the data model. More changes were needed on the coupler side, because previous coupled cases did not have samegrid_ao flag true.
Also, changes in the intel compiler or bios on chrysalis uncovered other needs about initialization of
mpi_reduce variables. (mpi_reduce is needed for comparisons between mct and moab fields,
in debug/verification mode)
Also add MOAB libs to perlmutter.
[BFB]