-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPL: Add field exclusions list for nonlinear maps. #6094
CPL: Add field exclusions list for nonlinear maps. #6094
Conversation
Add the user_nl_cpl namelist option nlmaps_exclude_fields. This is a list of fields that are to be excluded from the set that are nonlinearly mapped. For these excluded fields, the low-order linear map is used instead. The default is nlmaps_exclude_fields = 'Faxa_rainc', 'Faxa_rainl', 'Faxa_snowc', 'Faxa_snowl'
1cdc4ba
to
597b6a2
Compare
e3sm_integration on Chrysalis matches the dashboard except (1) that every test has a NML diff:
and (2) ERS_Ld3.ne30pg2_r05_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-nlmaps, the stealth-feature test, DIFFs. Both of these are expected. |
@golaz Rob and I agreed that defaulting the namelist variable to include the four preciptiation fluxes is best. Is that OK with you? This has two implications:
|
@ambrad : thank you for working on this quickly. We discussed it during the meeting this morning. We should go ahead with this option for v3. |
I'm going to call this "non-BFB" all the v3 cases are using nlmaps now. Our testing is lagging in bringing in those cases. |
I see. Do I interpret this correctly as follows?
|
right. Also when a PR makes any test non-BFB, I prefer to call it "non-BFB except for" or "non-BFB only in" instead of "BFB except for". Makes it easier to find the possibly non-BFB PRs in the git log. |
Re: testing, I checked that the following code modification makes the nlmaps test BFB with the current baseline, as expected and desired: --- a/cime_config/testmods_dirs/allactive/nlmaps/user_nl_cpl
+++ b/cime_config/testmods_dirs/allactive/nlmaps/user_nl_cpl
@@ -1 +1,2 @@
nlmaps_verbosity = 1
+nlmaps_exclude_fields = '','','','' |
@ambrad did you want to handle the integration? |
@rljacob Yes, I will do it unless you prefer someone else does. Edit: I see I forgot to assign myself, prompting Rob's question. Fixed. |
CPL: Add field exclusions list for nonlinear maps. Add the user_nl_cpl namelist option nlmaps_exclude_fields. This is a list of fields that are to be excluded from the set that are nonlinearly mapped. For these excluded fields, the low-order linear map is used instead. The default is nlmaps_exclude_fields = 'Faxa_rainc', 'Faxa_rainl', 'Faxa_snowc', 'Faxa_snowl' [non-BFB] for cases using nlmaps [NML] for all tests due to extra variable nlmaps_exclude_fields
Add the user_nl_cpl namelist option nlmaps_exclude_fields. This is a list of fields that are to be excluded from the set that are nonlinearly mapped. For these excluded fields, the low-order linear map is used instead. The default is
nlmaps_exclude_fields = 'Faxa_rainc', 'Faxa_rainl', 'Faxa_snowc', 'Faxa_snowl'
[non-BFB] for cases using nlmaps
[NML] for all tests due to extra variable nlmaps_exclude_fields