Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FATES type names to facilitate refactor #5849

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Update FATES type names to facilitate refactor #5849

merged 1 commit into from
Aug 24, 2023

Conversation

glemieux
Copy link
Contributor

@glemieux glemieux commented Jul 31, 2023 •
edited by bishtgautam
Loading

This pull request changes the names of a number of FATES use statements and type names
to be consistent with the associated FATES refactor. The FATES submodule pointer is
updated as a results as well.

[B4B] for non-fates tests

@glemieux glemieux mentioned this pull request Aug 8, 2023
Merged
5 tasks
@glemieux
Copy link
Contributor Author

glemieux commented Aug 8, 2023

Running e3sm_land_developer and e3sm_land_debug testing on perlmutter currently. @bishtgautam @peterdschwartz this should come in prior to #5555 and #5760.

@glemieux
Copy link
Contributor Author

glemieux commented Aug 8, 2023 •
edited
Loading

Perlmutter e3sm_land_developer tests are showing DIFFs against the master baseline for the fates runs as expected. There are a number TPUTCOMP results against the baseline, but otherwise all non-fates tests are b4b.

Perlmutter e3sm_land_debug tests are b4b with the expected exception of the one fates test.

@glemieux glemieux force-pushed the lnd/fates-refactor branch from f209450 to b8be65d Compare August 8, 2023 20:45
This was referenced Aug 10, 2023
Merged
Merged
@glemieux
Copy link
Contributor Author

@rgknox I confirmed that this points to https://github.com/NGEET/fates/releases/tag/sci.1.67.1_api.26.0.0 and not your API 27 tag.

@bishtgautam bishtgautam self-requested a review August 21, 2023 23:59
bishtgautam added a commit that referenced this pull request Aug 23, 2023
@bishtgautam
Merge branch 'lnd/fates-refactor' into next (PR #5849)
9025d57 
This pull request changes the names of a number of FATES use statements and type names
to be consistent with the associated FATES refactor. The FATES submodule pointer is
updated as a results as well.

[B4B] for non-fates tests
@bishtgautam bishtgautam merged commit 4b00636 into E3SM-Project:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishtgautam bishtgautam bishtgautam approved these changes

Assignees

@bishtgautam bishtgautam

Labels
FATES Land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glemieux @bishtgautam @rljacob