Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fates pointer to api 25.5 #5802

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

rgknox
Copy link
Contributor

@rgknox rgknox commented Jul 11, 2023

This set of changes brings compatibility with FATES up to API 25.5. The main changes to the
API update are a change to the FATES parameter file, and modifications to the coupling
interface to enable communication with drought deciduous plants.

[BFB] except for FATES

@rgknox
Copy link
Contributor Author

rgknox commented Jul 11, 2023

This set of changes should enable and precede: #5689

@rgknox
Copy link
Contributor Author

rgknox commented Jul 11, 2023

Still testing, @glemieux and I are working through some issues described here, that may be relevant: NGEET/fates#1041 (comment)
Will update when this is ready

@rgknox
Copy link
Contributor Author

rgknox commented Jul 11, 2023

I think this is ready now.

Updated code, results should be and are, b4b with non-fates. fates runs are not expected to be b4b, and pass. tests run on perlmutter pm-cpu

This directory has tests against master and is relevant for non-fates tests:
/pscratch/sd/r/rgknox/e3sm_tests/Ef6d87064e2-Fe1a3f730-fates-api-25-5

Here are exceptions (assuming known fails?):
FAIL ERS_D.ne11_oQU240.I20TRELM.pm-cpu_gnu RUN time=197
FAIL ERS.r05_r05.RMOSGPCC.pm-cpu_gnu.mosart-heat RUN time=19

I'm ignoring TPUTCOMP, since its a red herring on pm-cpu, its flagging in tests where no code is changed.

This directory is relevant for fates-only tests, which tests updates f85dcf3 and later, which fixed a fates crash :
/pscratch/sd/r/rgknox/e3sm_tests/Ef397337924-F6d424f46-fates-api-25-5_v2

bishtgautam added a commit that referenced this pull request Jul 20, 2023
This set of changes brings compatibility with FATES up to API 25.5. The main changes to the
API update are a change to the FATES parameter file, and modifications to the coupling
interface to enable communication with drought deciduous plants.

[BFB] except for FATES
@bishtgautam bishtgautam merged commit c0300fa into E3SM-Project:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants