Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update F compsets with mpas-seaice for prescribed ice mode #4483

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Aug 23, 2021

F20TR-MPASSI is added for 20th century transient AMIP with
prescribed ice mode from mpas-seaice. Existing F2010SC5-CMIP6-MPASSI
is renamed as F2010-MPASSI. Note that F2010SC5-CMIP6-MPASSI
was using use_case file 2010S_cam5_CMIP6.xml, which would override the
final v2 default values for clubb_tk1 and gw_convect_hcf.

[BFB] for existing compsets

F20TR-MPASSI is added for 20th century transient AMIP with
prescribed ice mode from mpas-seaice. Existing F2010SC5-CMIP6-MPASSI
is renamed as F2010-MPASSI. Note that F2010SC5-CMIP6-MPASSI
was using use_case file 2010S_cam5_CMIP6.xml, which would override the
final v2 default values for clubb_tk1 and gw_convect_hcf.

[BFB] for existing compsets
@wlin7 wlin7 added Atmosphere compset BFB PR leaves answers BFB labels Aug 23, 2021
@wlin7 wlin7 requested a review from jonbob August 23, 2021 16:38
@wlin7 wlin7 self-assigned this Aug 23, 2021
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection -- looks like the right long-names for using mpassi in these F-cases

@rljacob
Copy link
Member

rljacob commented Aug 23, 2021

Is anything still using 2010S_cam5_CMIP6.xml after this PR?

@wlin7
Copy link
Contributor Author

wlin7 commented Aug 24, 2021

Is anything still using 2010S_cam5_CMIP6.xml after this PR?

@rljacob This file and the associated compset, along with FC5AV1C-L and tests using it will be removed in the next PR coming in today.

wlin7 added a commit that referenced this pull request Aug 24, 2021
Update F compsets with mpas-seaice for prescribed ice mode

F20TR-MPASSI is added for 20th century transient AMIP with
prescribed ice mode from mpas-seaice. Existing F2010SC5-CMIP6-MPASSI
is renamed as F2010-MPASSI. Note that F2010SC5-CMIP6-MPASSI
was using use_case file 2010S_cam5_CMIP6.xml, which would override the
final v2 default values for clubb_tk1 and gw_convect_hcf.

[BFB] for existing compsets
@wlin7
Copy link
Contributor Author

wlin7 commented Aug 24, 2021

Merged to next.

wlin7 added a commit that referenced this pull request Aug 24, 2021
Remove obsolete eam and allactive compsets and the associated eam
use_case files, and update the compsets used in nightly test suites.

All compsets referring to AV1C or v0atm are removed.  F20TRC5-CMIP6
and F2010SC5-CMIP6 are no more needed (previously retained for ongoing
testings). Temporarily leave F2010SC5-CMIP6-MPASSI which is to be replaced
with F2010-MPASSI via #4483. Remainging use case files referring to av1c
are removed, except for two used by MMF tests.

The following compsets are replaced in nightly test suites.

. FC5AV1C-L with F2010
. A_WCYCL1850 and A_WCYCL1850S_CMIP6 with WCYCL1850
. FC5AV1C-H01A with F2010 as there is no v2 compset just for hires
. A_WCYCL1950S_CMIP6_HR and A_WCYCL2000_H01AS with WCYCL1950 as a placeholder

[non-BFB] Virtually for all tests. Tests using the old compsets would appear missing
          while new tests would appear correspondingly.
@wlin7 wlin7 merged commit 4683974 into master Aug 25, 2021
@wlin7
Copy link
Contributor Author

wlin7 commented Aug 25, 2021

Merged to master. Today's tests diffs on cdash are all accounted for and unrelated to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere BFB PR leaves answers BFB compset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants