Update MPAS components for v1 ACME

[douglasjacobsen]

This merge updates the MPAS components to include the scientific features for ACME v1 simulations.

Additionally, it makes driver changes required to handle frazil ice and BGC between MPAS-O and MPAS-CICE.

[CC]
[NML]

[rljacob]

BFB? CC?

[worleyph]

On Titan using PGI, the preprocessor (.F to .f90) interprets '' as the last nonblank character on a line as a continuation character. In consequence, the comment lines (1132-1136) in

   mpas_cice_advection_incremental_remap.F 

are turned into one very long comment line, and compilation then fails with the error message:

  PGF90-S-0285-Source line too long (mpas_cice_advection_incremental_remap.f90: 1134)

I replaced these with a different character (not as aesthetically pleasing) and mpas-cice compiled with no problems.

[douglasjacobsen]

@worleyph Thanks for testing this, I'll make sure those changes happen on the MPAS side.

[worleyph]

Also, on Titan and with PGI something is not working right with some of the timer names in mpas-cice. They are 512 characters long, and mostly blank. The list follows (number of characters, nonblank characters):

   512  XXX_conservationCheck
   512  XXX_geographicalVectors
   512  XXX_regionalStatistics
   512  XXX_ridgingDiagnostics
   512  XXX_temperatures

where XXX is one of

   compute
   finalize
   init
   precompute
   reset_alarm
   restart
   write

They all appear to be generated in routines in mpas_cice_analysis_driver.F by logic of the form

   timerName = trim(computeTimerPrefix) // poolItr % memberName(1:nameLength)    

The fix may be to add the following line:

   timerName = trim(timerName)

after each line of the indicated form. I'll update after my test job runs, but I may not get to this until tomorrow. ... Nope - that did not change anything. Initializing the variable timerName to " " did nothing either. I'll keep looking for a fix, but if someone know how to fix this, please speak up :-).

[douglasjacobsen]

@worleyph Were you talking about these lines? https://github.com/ACME-Climate/MPAS/blob/cice/develop/src/core_cice/shared/mpas_cice_advection_incremental_remap.F#L1132

[worleyph]

@douglasjacobsen , yes, those lines.

[whlipscomb]

@douglasjacobsen and @worleyph, Could we fix the offending lines by putting exclamation points at the end, like so?

   !                            /      E0       \                                      !                                      

[douglasjacobsen]

Changing the \ characters to | works. I'm testing adding an ending ! as @whlipscomb suggested now.

[worleyph]

Update on long mpas-cice timers. The problem is not in the string operations in mpas_cice_analysis_driver.F . The string sizes in mpas_cice_analysis_driver.F are accurate. The string sizes are not accurate inside of mpas_timer.F . The logic is

      trimed_name = trim(timer_name)
      nlen = len(trimed_name)

   ...

   #ifdef MPAS_PERF_MOD_TIMERS
      call t_startf(trimed_name)
   !pw++                       
      if ( domain_info % my_proc_id == 0 ) then
         if (nlen > 50) then
            write(6,*) "Long Timer Name:", nlen, trimed_name
    call flush(6)
         endif
      endif
   !pw-- 

The nlen is "accurate" in that trimed_name is 512 characters long.

[douglasjacobsen]

Adding ! at the end does fix the issue as well. I've submitted a PR for MPAS to have the issue fixed.

[douglasjacobsen]

@worleyph Can you test the following for the long timer names?

NOTE: You have to make the change in all MPAS components that you will be using in a run (i.e. if you are using the B case, you need to make the change in all MAPS-O, MPAS-LI, and MPAS-CICE).

Change this line:
https://github.com/ACME-Climate/MPAS/blob/cice/develop/src/framework/mpas_timer.F#L75

From: character (len=len(timer_name)) :: trimed_name
To: character (len=len_trim(timer_name)) :: trimed_name

And this line:
https://github.com/ACME-Climate/MPAS/blob/cice/develop/src/framework/mpas_timer.F#L230

From: character (len=len(timer_name)) :: trimed_name !< Trimed timer name
To: character (len=len_trim(timer_name)) :: trimed_name !< Trimed timer name

[worleyph]

@douglasjacobsen , will do. I'm trying passing in trim(timer_name) directly to t_startf/t_stopf at the moment. Once this is complete (maybe 30 minutes), I'll try your fix.

[worleyph]

Okay, replacing

      trimed_name = trim(timer_name)
      call t_startf(trimed_name)

by

      call t_startf(trim(timer_name))

(and similarly for t_stopf) worked. I'll try the above next.

[worleyph]

@douglasjacobsen , this change

   From: character (len=len(timer_name)) :: trimed_name
   To: character (len=len_trim(timer_name)) :: trimed_name

also worked. I'll start using this.

Thanks.

Pat

[douglasjacobsen]

Merged to next