Add phosphorous deposition stream file to ALM #391

acme-y9s · 2015-10-26T14:17:57Z

This commit adds phosphorus deposition stream file to ALM land surface model.
This procedure is similar to add nitrogen deposition stream file.
It is turned on by default, and will not change the result due to the
phosphorus cycle turned off by default.
It will change the result if the phosphorus cycle turned on.

[NML]
[BFB]

rljacob · 2015-10-26T14:22:12Z

scripts/out file should not have been committed.

rljacob · 2015-10-26T14:23:05Z

3 commits all with the same commit message and 30 files changed? That is not enough information.

bishtgautam · 2015-10-26T16:39:15Z

@acme-y9s : Could you also update the message describing this PR?

See the template at https://acme-climate.atlassian.net/wiki/display/Docs/Commit+message+template
Things missing are :
- [BFB], [non-BFB], etc key
- Jira task id
A more descriptive message describing this PR (see Add dynamic roots #372)

Thanks.

bishtgautam · 2015-10-26T16:40:03Z

@acme-y9s Btw, thanks for squashing three commits into a single commit.

bishtgautam · 2015-10-26T18:08:52Z

Do we expect any acme_developer tests to fail when this PR is merged into next?

acme-y9s · 2015-10-26T18:43:40Z

I don't think it will cause the acme_developer tests to fail. I just added a new stream file and it will only change the result when the P cycle is on.

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:6C2D6C04-73B5-4C48-9606-0B2778A9464F]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Monday, October 26, 2015 at 2:08 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

Do we expect any acme_developer tests to fail when this PR is merged into next?

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-151231136.

bishtgautam · 2015-10-26T19:53:32Z

@acme-y9s: This PR is not just making changes to namelist, but is also modifying source-code. Thus, please run acme_developer tests on Titan/Edison/Cetus/Mira and report failure or success of tests.

git checkout acme-y9s/pdepos

git log -n 5 --oneline --graph --decorate
* 874fd9a (HEAD, origin/acme-y9s/pdepos, acme-y9s/pdepos)   Add phosphorus deposition new stream file
*   526f878 Merge branch 'yangx/lnd/phosphorus_pr_2nd' (PR #272)
|\  
| * 739ffe0 (origin/yangx/lnd/phosphorus_pr_2nd) Adding phosphorus cycle dynamics into ACME land model
* |   6783a11 Merge branch 'matthewhoffman/mpasli/add-mpasli-component'
|\ \  
| * | a5d2244 Set GLC grid to be the same as LND grid for f09_g16

Since you created acme-y9s/pdepos branch starting from master at 526f878

Step-1: Generate baselines with 526f878 for acme_developer,
Step-2: Compare against baselines generated in step-1 with acme-y9s/pdepos

Btw, you forgot to include 'lnd' in your branch name, which should have been acme-y9s/lnd/pdepos. No need to fix the branch name for this PR, but something to keep in mind when you create the next branch.

acme-y9s · 2015-10-26T20:39:15Z

I do not have accounts on all Machines. I tried the test suit last Thursday on Titan, but have not finished all the procedures yet, will wrap up it on Titan tomorrow.

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:7C463665-DA22-4909-92F0-CEC55E39B7BA]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Monday, October 26, 2015 at 3:53 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

@acme-y9shttps://github.com/acme-y9s: This PR is not just making changes to namelist, but is also modifying source-code. Thus, please run acme_developer tests on Titan/Edison/Cetus/Mira and report failure or success of tests.

git checkout acme-y9s/pdepos

git log -n 5 --oneline --graph --decorate

874fd9a (HEAD, origin/acme-y9s/pdepos, acme-y9s/pdepos) Add phosphorus deposition new stream file
526f878 Merge branch 'yangx/lnd/phosphorus_pr_2nd' (PR Adding phosphorus cycle dynamics into ACME land model #272)
|
| * 739ffe0 (origin/yangx/lnd/phosphorus_pr_2nd) Adding phosphorus cycle dynamics into ACME land model
| 6783a11 Merge branch 'matthewhoffman/mpasli/add-mpasli-component'
|\
| * | a5d2244 Set GLC grid to be the same as LND grid for f09_g16

Since you created acme-y9s/pdepos branch starting from master at 526f878

Step-1: Generate baselines with 526f878 for acme_developer,
Step-2: Compare against baselines generated in step-1 with acme-y9s/pdepos

Btw, you forgot to include 'lnd' in your branch name, which should have been acme-y9s/lnd/pdepos. No need to fix the branch name for this PR, but something to keep in mind when you create the next branch.

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-151264258.

bishtgautam · 2015-10-26T21:19:39Z

I didn't mean to imply that you have to run the tests on all machines. Running the acme_developer test on a single machine is sufficient.

bishtgautam · 2015-10-28T02:11:38Z

For the record, I added line breaks to the single line message describing this PR.

rljacob · 2015-10-29T22:18:49Z

Please rename this PR to be more descriptive.

bishtgautam · 2015-10-30T17:48:28Z

@acme-y9s : Any luck getting the tests running on Titan? If Titan is taking too long, Edison might be quicker to get the testing done.

acme-y9s · 2015-10-30T17:58:58Z

I tried several times, but It seems to me not all the cases are done. You can see there are some cases are missed in the below summary. It is my first time doing this test suit,I am not sure what exactly happened.
Maybe, you have better explanation for this. Thank you!

PASS ERS.f19_g16_rx1.A.titan_pgi

PASS ERS.f19_g16_rx1.A.titan_pgi.memleak

PASS ERS.f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS.f19_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

PASS ERS.f19_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

FAIL ERS.f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS.f45_g37.B1850C5.titan_pgi

PASS ERS.f45_g37.B1850C5.titan_pgi.memleak

PASS ERS.f45_g37.B1850C5.titan_pgi.compare_hist.baseline_testcases

PASS ERS.f45_g37.B1850C5.titan_pgi.memcomp.baseline_testcases

PASS ERS.f45_g37.B1850C5.titan_pgi.tputcomp.baseline_testcases

FAIL ERS.f45_g37.B1850C5.titan_pgi.C.acme_dev.nlcomp

PASS ERS.f45_g37_rx1.DTEST.titan_pgi

PASS ERS.f45_g37_rx1.DTEST.titan_pgi.memleak

PASS ERS.f45_g37_rx1.DTEST.titan_pgi.compare_hist.baseline_testcases

PASS ERS.f45_g37_rx1.DTEST.titan_pgi.memcomp.baseline_testcases

PASS ERS.f45_g37_rx1.DTEST.titan_pgi.tputcomp.baseline_testcases

FAIL ERS.f45_g37_rx1.DTEST.titan_pgi.C.acme_dev.nlcomp

PASS ERS.ne30_g16_rx1.A.titan_pgi

PASS ERS.ne30_g16_rx1.A.titan_pgi.memleak

PASS ERS.ne30_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS.ne30_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS.ne30_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 12.876 tput_percent_decr = 10.4

FAIL ERS.ne30_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP.f19_g16_rx1.A.titan_pgi

PASS ERS_IOP.f19_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP.f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP.f19_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP.f19_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 0.7850000 tput_percent_decr = 2.15

PASS ERS.f19_g16_rx1.A.titan_pgi

PASS ERS.f19_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP.f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP.f45_g37_rx1.DTEST.titan_pgi

PASS ERS_IOP.f45_g37_rx1.DTEST.titan_pgi.memleak

PASS ERS_IOP.f45_g37_rx1.DTEST.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP.f45_g37_rx1.DTEST.titan_pgi.memcomp.baseline_testcases

PASS ERS_IOP.f45_g37_rx1.DTEST.titan_pgi.tputcomp.baseline_testcases

PASS ERS.f45_g37_rx1.DTEST.titan_pgi

PASS ERS.f45_g37_rx1.DTEST.titan_pgi.memleak

FAIL ERS_IOP.f45_g37_rx1.DTEST.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP.ne30_g16_rx1.A.titan_pgi

PASS ERS_IOP.ne30_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP.ne30_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP.ne30_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP.ne30_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 10.563 tput_percent_decr = 8.67

PASS ERS.ne30_g16_rx1.A.titan_pgi

PASS ERS.ne30_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP.ne30_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP4c.f19_g16_rx1.A.titan_pgi

PASS ERS_IOP4c.f19_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP4c.f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP4c.f19_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP4c.f19_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 1.296 tput_percent_decr = 3.68

PASS ERS.f19_g16_rx1.A.titan_pgi

PASS ERS.f19_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP4c.f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP4c.ne30_g16_rx1.A.titan_pgi

PASS ERS_IOP4c.ne30_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP4c.ne30_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP4c.ne30_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP4c.ne30_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 10.91 tput_percent_decr = 12.1

PASS ERS.ne30_g16_rx1.A.titan_pgi

PASS ERS.ne30_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP4c.ne30_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP4p.f19_g16_rx1.A.titan_pgi

PASS ERS_IOP4p.f19_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP4p.f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP4p.f19_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP4p.f19_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 0.2679999

PASS ERS.f19_g16_rx1.A.titan_pgi

PASS ERS.f19_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP4p.f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS ERS_IOP4p.ne30_g16_rx1.A.titan_pgi

PASS ERS_IOP4p.ne30_g16_rx1.A.titan_pgi.memleak

PASS ERS_IOP4p.ne30_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS ERS_IOP4p.ne30_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

FAIL ERS_IOP4p.ne30_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 7.7010000 tput_percent_decr = 5.86

PASS ERS.ne30_g16_rx1.A.titan_pgi

PASS ERS.ne30_g16_rx1.A.titan_pgi.memleak

FAIL ERS_IOP4p.ne30_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

PASS NCK.f19_g16_rx1.A.titan_pgi

PASS NCK.f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

FAIL NCK.f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

RUN PEA_P1_M.f45_g37_rx1.A.titan_pgi.C.acme_dev

PASS SMS.f19_f19.I1850CLM45CN.titan_pgi

PASS SMS.f19_f19.I1850CLM45CN.titan_pgi.memleak

PASS SMS.f19_f19.I1850CLM45CN.titan_pgi.compare_hist.baseline_testcases

PASS SMS.f19_f19.I1850CLM45CN.titan_pgi.memcomp.baseline_testcases

FAIL SMS.f19_f19.I1850CLM45CN.titan_pgi.tputcomp.baseline_testcases

COMMENT tput_decr = 0.34

FAIL SMS.f19_f19.I1850CLM45CN.titan_pgi.C.acme_dev.nlcomp

PASS SMS.ne30_f19_g16_rx1.A.titan_pgi

PASS SMS.ne30_f19_g16_rx1.A.titan_pgi.memleak

PASS SMS.ne30_f19_g16_rx1.A.titan_pgi.compare_hist.baseline_testcases

PASS SMS.ne30_f19_g16_rx1.A.titan_pgi.memcomp.baseline_testcases

PASS SMS.ne30_f19_g16_rx1.A.titan_pgi.tputcomp.baseline_testcases

FAIL SMS.ne30_f19_g16_rx1.A.titan_pgi.C.acme_dev.nlcomp

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:D15DB313-476A-4287-A5D4-9138C504B12C]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Friday, October 30, 2015 at 1:48 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

@acme-y9shttps://github.com/acme-y9s : Any luck getting the tests running on Titan? If Titan is taking too long, Edison might be quicker to get the testing done.

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-152599820.

bishtgautam · 2015-10-30T18:17:01Z

Can you point me to your test directory on Titan, so I can investigate what is the cause of *nlcomp failures?

acme-y9s · 2015-10-30T18:28:28Z

For this nlcomp failures, I think it should be related to I changed the namelist files. My test directory is /lustre/atlas1/cli112/scratch/y9s/acme_dev/
The directory for baseline is /lustre/atlas1/cli112/scratch/y9s/acme_baseline

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:905BD06B-27CB-41B1-851B-66B8F1DFE1D1]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Friday, October 30, 2015 at 2:17 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

Can you point me to your test directory on Titan, so I can investigate what is the cause of *nlcomp failures?

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-152607250.

bishtgautam · 2015-10-30T18:36:35Z

I can't access your scratch directory. Can you either:

change permission of your scratch directory, or
copy the TestStatus.log for the failing tests in /lustre/atlas1/cli112/proj-shared/y9s/

You are probably correct that the nlcomp failures are due to changes to namelist files, but let's confirm it.

acme-y9s · 2015-10-30T19:11:36Z

I copied my whole test directory to proj-shared, /lustre/atlas1/cli112/proj-shared/y9s/acme_dev

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:58A2CE67-372F-44F3-B814-ABF14D096B42]

From: Azamat Mametjanov <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Friday, October 30, 2015 at 2:36 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

I can't access your scratch directory. Can you either:

change permission of your scratch directory, or
copy the TestStatus.log for the failing tests in /lustre/atlas1/cli112/proj-shared/y9s/

You are probably correct that the nlcomp failures are due to changes to namelist files, but let's confirm it.

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-152612022.

bishtgautam · 2015-10-30T19:51:00Z

So it turns out that you didn't have correct version of python loaded

more /lustre/atlas1/cli112/proj-shared/y9s/acme_dev/ERS.f19_g16_rx1.A.titan_pgi.C.acme_dev/TestStatus.out 
FAIL: Python 2.7+ is required, you have 2.6
FAIL: Python 2.7+ is required, you have 2.6

Do a module load python before resubmitting the tests.

But, before you resubmit the tests, can you confirm that you generated the baselines with git hash 526f878 and are running comparison tests with git hash 874fd9a.

acme-y9s · 2015-10-30T20:15:48Z

A quick question about how to run the test in background ? I used the below command line

nohup ./create_test -xml_mach titan -xml_compiler pgi -xml_category acme_developer -testid acme_dev -testroot /lustre/atlas1/cli112/scratch/y9s/acme_dev -baselineroot /lustre/atlas1/cli112/scratch/y9s/acme_baseline -compare baseline_testcases -project cli112 >/lustre/atlas1/cli112/scratch/y9s/campare.log

However, it did not work. Any ideas? Thank you!

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:D2C8C993-7FD4-4D1E-8374-4172D997350F]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Friday, October 30, 2015 at 3:51 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

So it turns out didn't have correct version of python loaded

more /lustre/atlas1/cli112/proj-shared/y9s/acme_dev/ERS.f19_g16_rx1.A.titan_pgi.C.acme_dev/TestStatus.out
FAIL: Python 2.7+ is required, you have 2.6
FAIL: Python 2.7+ is required, you have 2.6

Do a module load python before resubmitting the tests.

But, before you resubmit the tests, can you confirm that you generated the baselines with git hash 526f878 and are running comparison tests with git hash 874fd9a.

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-152635526.

acme-y9s · 2015-10-30T20:16:23Z

Thank you , I will load the correct version of python and try it again.
I am pretty sure I generated the baselines with git hash 526f878 and are running comparison tests with git hash 874fd9a.

Xiaoying Shi
Climate Change Science Institute
Environmental Sciences Division
Building 2040, Room E222, MS-6301
Oak Ridge National Laboratory
P.O. Box 2008
Oak Ridge, TN 37831-6301
Office: 865-241-9199 Mobile: 865-804-1900
shix@ornl.govmailto:maoj@ornl.gov 865-574-9501 (fax)
[cid:1291FF08-3C60-4D7A-B258-3B64F00AA31E]

From: Gautam Bisht <notifications@github.com mailto:notifications@github.com>
Reply-To: ACME-Climate/ACME <reply@reply.github.com mailto:reply@reply.github.com>
Date: Friday, October 30, 2015 at 3:51 PM
To: ACME-Climate/ACME <ACME@noreply.github.com mailto:ACME@noreply.github.com>
Cc: Xiaoying Shi <shix@ornl.gov mailto:shix@ornl.gov>
Subject: Re: [ACME] Acme y9s/pdepos (#391)

So it turns out didn't have correct version of python loaded

more /lustre/atlas1/cli112/proj-shared/y9s/acme_dev/ERS.f19_g16_rx1.A.titan_pgi.C.acme_dev/TestStatus.out
FAIL: Python 2.7+ is required, you have 2.6
FAIL: Python 2.7+ is required, you have 2.6

Do a module load python before resubmitting the tests.

But, before you resubmit the tests, can you confirm that you generated the baselines with git hash 526f878 and are running comparison tests with git hash 874fd9a.

Reply to this email directly or view it on GitHubhttps://github.com//pull/391#issuecomment-152635526.

bishtgautam · 2015-10-30T20:28:58Z

Use the screen command to launch a command in the background.

# Start a screen
>screen

# Do something
> ls

# Detach from the screen (Control key + a; followed by d)
> Ctrl+a  d

#Reattach to the previously started screen
> screen -r

# Run test
> ./create_test -xml_mach titan  ...

# Detach from a screen
> Ctrl+a  d

# Remember the hostname on which you started the screen
> echo $HOSTNAME

Log out, go home and enjoy the weekend. The next time you do login Titan, remember to log back into the same $HOSTNAME on which you started the screen and reattach to it via screen -r.

acme-y9s · 2015-11-02T19:24:31Z

This PR creates two expected nameless failures:

FAIL ERS.f45_g37.B1850C5.titan_pgi.C.acme_dev.nlcomp
FAIL SMS.f19_f19.I1850CLM45CN.titan_pgi.C.acme_dev.nlcomp

acme-y9s · 2015-11-02T19:25:11Z

Need to upload inputdata/lnd/clm2/pdepdata/fpdep_clm_hist_simyr2000_1.9x2.5_c150929.nc to ACME inputdata server.

acme-y9s · 2015-11-03T17:48:19Z

The phosphorus deposition data has been uploaded to ACME input data server.

bishtgautam · 2015-11-03T18:00:08Z

Thanks for the update. I will try to merge this in next.

This commit adds phosphorus deposition stream file to ALM land surface model. This procedure is similar to add nitrogen deposition stream file. It is turned on by default, and will not change the result due to the phosphorus cycle turned off by default. It will change the result if the phosphorus cycle turned on. [NML] [BFB] Conflicts: components/clm/bld/CLMBuildNamelist.pm components/clm/src/biogeochem/CNEcosystemDynMod.F90 components/clm/src/biogeochem/CNStateType.F90 components/clm/src/main/clm_driver.F90 components/clm/src/main/clm_initializeMod.F90

bishtgautam · 2015-12-04T21:34:06Z

@jgfouca : This PR is merged in next and has namelist changes. So, I expect that we will see four NLFAIL failures in nightly tests.

jgfouca · 2015-12-04T21:38:01Z

@bishtgautam , thanks for the heads-up. I will rebless when I see them.

This reverts commit ed7e5af, reversing changes made to 0f74414.

This reverts commit dc2fe97. This commit adds phosphorus deposition stream file to ALM land surface model. This procedure is similar to add nitrogen deposition stream file. It is turned on by default, and will not change the result due to the phosphorus cycle turned off by default. It will change the result if the phosphorus cycle turned on. [NML] [BFB]

This commit adds phosphorus deposition stream file to ALM land surface model. This procedure is similar to add nitrogen deposition stream file. It is turned on by default, and will not change the result due to the phosphorus cycle turned off by default. It will change the result if the phosphorus cycle turned on. [NML] [BFB] Conflicts: components/clm/bld/CLMBuildNamelist.pm components/clm/src/biogeochem/CNEcosystemDynMod.F90 components/clm/src/biogeochem/CNStateType.F90 components/clm/src/main/clm_driver.F90 components/clm/src/main/clm_initializeMod.F90

bishtgautam · 2015-12-07T17:04:42Z

@jgfouca : Now the commit is in master and there would be similar namelist failures on the nightly tests for master.

@dmricciuto : With this merge a new phosphorous deposition stream can be read in, which is presently protected with ifndef CPL_BYPASS at clm_driver.F90#L404. The CPL_BYPASS code might need to be updated for the case when the new phosphorous deposition has to be read in and the coupler bypass approach is being used.

PR #388 - Makefilecleanup PR #391 - fix testreporter.pl, SMS and PFS test output, cori queue settings PR #392 - Resubmit sets continue run Conflicts: cime_config/cesm/allactive/config_compsets.xml driver_cpl/cime_config/config_component.xml Tested in geotrace3_cac_n31_cam5_4_51 - BFB

Improve complete_run workflow

rljacob assigned bishtgautam Oct 26, 2015

Add phosphorus deposition new stream file

874fd9a

acme-y9s force-pushed the acme-y9s/pdepos branch from 069ad8c to 874fd9a Compare October 26, 2015 16:25

bishtgautam added the Land label Oct 26, 2015

rljacob changed the title ~~Acme y9s/pdepos~~ Add phosphorous deposition stream file to ALM Nov 2, 2015

bishtgautam added BFB PR leaves answers BFB NML labels Nov 3, 2015

douglasjacobsen modified the milestone: v1.0 Alpha Nov 3, 2015

rljacob added the Stealth PR has feature which, if turned on, could change climate. fka FCC label Nov 3, 2015

bishtgautam pushed a commit that referenced this pull request Dec 5, 2015

Revert "Merge branch 'acme-y9s/pdepos' into next (PR #391)"

dc2fe97

This reverts commit ed7e5af, reversing changes made to 0f74414.

bishtgautam merged commit 874fd9a into master Dec 7, 2015

jgfouca deleted the acme-y9s/pdepos branch August 31, 2016 02:48

yunpengshan2014 pushed a commit that referenced this pull request Apr 2, 2024

Merge pull request #391 from forsyth2/complete-run-workflow

aa581a3

Improve complete_run workflow

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add phosphorous deposition stream file to ALM #391

Add phosphorous deposition stream file to ALM #391

acme-y9s commented Oct 26, 2015

rljacob commented Oct 26, 2015

rljacob commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

acme-y9s commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

acme-y9s commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 28, 2015

rljacob commented Oct 29, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Nov 2, 2015

acme-y9s commented Nov 2, 2015

acme-y9s commented Nov 3, 2015

bishtgautam commented Nov 3, 2015

bishtgautam commented Dec 4, 2015

jgfouca commented Dec 4, 2015

bishtgautam commented Dec 7, 2015

Add phosphorous deposition stream file to ALM #391

Add phosphorous deposition stream file to ALM #391

Conversation

acme-y9s commented Oct 26, 2015

rljacob commented Oct 26, 2015

rljacob commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

acme-y9s commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

acme-y9s commented Oct 26, 2015

bishtgautam commented Oct 26, 2015

bishtgautam commented Oct 28, 2015

rljacob commented Oct 29, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

acme-y9s commented Oct 30, 2015

bishtgautam commented Oct 30, 2015

acme-y9s commented Nov 2, 2015

acme-y9s commented Nov 2, 2015

acme-y9s commented Nov 3, 2015

bishtgautam commented Nov 3, 2015

bishtgautam commented Dec 4, 2015

jgfouca commented Dec 4, 2015

bishtgautam commented Dec 7, 2015