Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update machine files to match new directory names at NERSC #3517

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Mar 26, 2020

This PR updates the machine files to reflect directory name changes from "acme" to "e3sm" on cori-knl and cori-haswell. It was cherry-picked from #3516 with some other slight modifications.

[BFB]

@jonbob jonbob requested review from darincomeau and ndkeen March 26, 2020 22:00
@jonbob jonbob self-assigned this Mar 26, 2020
@darincomeau
Copy link
Member

@jonbob thanks for bringing this in. I built and ran a GMPAS-DIB-IAF-ISMF.T62_oEC60to30v3wLI 5 day test successfully - any other testing you'd like me to do?

@jonbob
Copy link
Contributor Author

jonbob commented Mar 26, 2020

How'd you beat me through the queues?? No, if you're happy then I'm happy, @darincomeau !

@stephenprice
Copy link
Contributor

If this is the new 1.2 tag I'm happy to try out a B-case test at some point.

@darincomeau
Copy link
Member

@stephenprice I think what you're really after is #3513, which should be the last of the code changes needed to bring into 1.2.

@jonbob
Copy link
Contributor Author

jonbob commented Mar 26, 2020

@stephenprice - I'll aim to get both PR's in as soon as possible, so hopefully we'll have something for you to test on Monday

@stephenprice
Copy link
Contributor

Great. I'll look for it. Thanks

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

@ndkeen - whenever you have a chance, could you please make sure this looks right to you? The cherry-pick of your commit wasn't clean and I just want to be sure

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

@darincomeau - what compiler did you use for your test? So far my tests are passing with intel but failing with gnu...

@darincomeau
Copy link
Member

@darincomeau - what compiler did you use for your test? So far my tests are passing with intel but failing with gnu...

I only used intel - I'll try gnu now.

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

@darincomeau - for what it's worth, I don't think the gnu problem is related to this PR...

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

And it may be an issue mostly for CAM -- I tried a SMS.ne4_oQU240.A_WCYCL1850.cori-knl_gnu test and it fails when it's initializing the atm

Copy link
Contributor

@ndkeen ndkeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I see I also missed the "acme" in config_compilers which would affect ALBANY builds. So will have to make another PR to correct that on master.

@darincomeau
Copy link
Member

And it may be an issue mostly for CAM -- I tried a SMS.ne4_oQU240.A_WCYCL1850.cori-knl_gnu test and it fails when it's initializing the atm

Ah yeah I was only doing a G-case. My gnu case compiled, just waiting in the queue, but I suppose that won't be all that helpful.

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

Thanks @ndkeen

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

@darincomeau - it will still be useful to see if gnu has problems beyond CAM. Thanks!

@darincomeau
Copy link
Member

Yeah the G-case with gnu did indeed die, I think at the first time step. I don't see any errors in the component logs, but from the e3sm.log:

 133:
 133: Backtrace for this error:
 134: #0  0x20f205af in ???
 134:   at /home/abuild/rpmbuild/BUILD/glibc-2.26/nptl/../sysdeps/unix/sysv/linux/x86_64/sigaction.c:0
 134: #1  0x204f3c2d in ???```

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

Yeah, I saw similar things. But I'm pretty sure it has nothing to do with these paths -- so I'll get this PR in and maybe we can open an issue about gnu

@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

Oops, I put this in the wrong PR:
@ndkeen has an open issue about GNU being broken on cori (#3270)

@jonbob jonbob merged commit b7c7036 into maint-1.2 Mar 27, 2020
@jonbob
Copy link
Contributor Author

jonbob commented Mar 27, 2020

merged to maint-1.2

@jonbob jonbob deleted the jonbob/maint-1.2/update-nersc branch March 27, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants