Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mpas source framework for inc files #3367

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Update mpas source framework for inc files #3367

merged 1 commit into from
Jan 15, 2020

Conversation

mark-petersen
Copy link
Contributor

This is a minor MPAS framework update. It does not alter E3SM execution. It creates two new autogenerated config files on compile so that, in the future, each core may create a core_config module and include all the config flags at once, rather than declare each variable individually.

[BFB]

@mark-petersen mark-petersen added the BFB PR leaves answers BFB label Dec 23, 2019
@mark-petersen mark-petersen requested a review from jonbob December 23, 2019 16:04
@mark-petersen
Copy link
Contributor Author

Passed:

./create_test -p acme -q debug --walltime 00:30:00 \
  PET_Ln3.T62_oEC60to30v3wLI.GMPAS-DIB-IAF-ISMF.cori-knl_intel

Also test compiled stand-alone MPAS with all cores, with gnu and intel on LANL IC.

@rljacob rljacob requested a review from jgfouca December 27, 2019 18:28
jgfouca
jgfouca approved these changes Jan 2, 2020
View reviewed changes
Copy link
Member

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any implications for the build system.

@mark-petersen
Copy link
Contributor Author

@jonbob this is ready to merge when the repo is open.

jonbob
jonbob approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a visual inspection

jonbob added a commit that referenced this pull request Jan 14, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_191223' into next (PR #3367)
fd72d14 
Update mpas source framework for inc files

This PR brings in a new mpas-source submodule with a minor MPAS framework
update. It does not alter E3SM execution.  It creates two new autogenerated
config files on compile so that, in the future, each core may create a
core_config module and include all the config flags at once, rather than
declare each variable individually.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Jan 14, 2020

Merged to next

jonbob added a commit that referenced this pull request Jan 15, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_191223' (PR #3367)
11eca88 
Update mpas source framework for inc files

This PR brings in a new mpas-source submodule with a minor MPAS framework
update. It does not alter E3SM execution.  It creates two new autogenerated
config files on compile so that, in the future, each core may create a
core_config module and include all the config flags at once, rather than
declare each variable individually.

[BFB]
@jonbob jonbob merged commit 990d38b into master Jan 15, 2020
@jonbob
Copy link
Contributor

jonbob commented Jan 15, 2020

Merged to master

@jonbob jonbob deleted the mark-petersen/update_mpas_191223 branch January 15, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgfouca jgfouca jgfouca approved these changes

@jonbob jonbob jonbob approved these changes

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-albany-landice mpas-ocean mpas-seaice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mark-petersen @jonbob @jgfouca @rljacob