Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init qrl_idx to 0.0 in first step #3324

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Init qrl_idx to 0.0 in first step #3324

merged 1 commit into from
Feb 4, 2020

Conversation

ndkeen
Copy link
Contributor

@ndkeen ndkeen commented Nov 21, 2019 •
edited by singhbalwinder
Loading

Add one line (in clubb_intr.F90) that initializes array qrl_idx on the first step.

call pbuf_set_field(pbuf2d, qrl_idx, 0.0_r8)

Fixes #3142
Fixes #3061

[BFB]

@ndkeen
Copy link
Contributor Author

ndkeen commented Nov 21, 2019 •
edited
Loading

These tests now complete:

SMS_D_PT_PMx1_Ld1.ne16_ne16.FC5AV1C-L.cori-knl_intel
SMS_D_PT_PMx1_Ld1.ne30_ne30.FC5AV1C-L.cori-knl_intel
SMS_D_PT_PMx1_Ld1.ne120_ne120.FC5AV1C-L.cori-knl_intel

I also ran SMS_PT_Ld2.ne30_ne30.FC5AV1C-L.cori-knl_intel with this branch and then compared the result with the same test using a master from Nov 6th and the results were identical.

What other tests would others want to see here? It seems like running e3sm_developer is not appropriate as this error isn't caught there (though I do think we need a DEBUG ne16 and/or ne30 ATM test).

@rljacob rljacob removed the request for review from singhbalwinder November 23, 2019 02:18
@singhbalwinder
Copy link
Contributor

Thanks @ndkeen for fixing this bug. Do we know why it appears with ne16 or ne30 but not with ne4?

@ndkeen
Copy link
Contributor Author

ndkeen commented Nov 26, 2019

No I don't.

@singhbalwinder singhbalwinder mentioned this pull request Nov 26, 2019
Open
@ndkeen ndkeen mentioned this pull request Dec 20, 2019
Closed
@ndkeen
Copy link
Contributor Author

ndkeen commented Dec 20, 2019

Why would this not be merged?

@AaronDonahue AaronDonahue added the BFB PR leaves answers BFB label Jan 30, 2020
AaronDonahue added a commit that referenced this pull request Jan 30, 2020
@AaronDonahue
Merge branch 'ndk/atm/init_qrl_idx' into next (PR #3324)
4cf0151 
Add one line (in clubb_intr.F90) that initializes array qrl_idx on the first step.

call pbuf_set_field(pbuf2d, qrl_idx, 0.0_r8)

Fixes #3142
Fixes #3061

[BFB]
AaronDonahue added a commit that referenced this pull request Feb 4, 2020
@AaronDonahue
Merge branch 'ndk/atm/init_qrl_idx' (PR #3324)
1929c29 
Add one line (in clubb_intr.F90) that initializes array qrl_idx on the first step.

call pbuf_set_field(pbuf2d, qrl_idx, 0.0_r8)

Fixes #3142
Fixes #3061

[BFB]
@AaronDonahue AaronDonahue merged commit 00d800a into master Feb 4, 2020
@AaronDonahue AaronDonahue deleted the ndk/atm/init_qrl_idx branch February 4, 2020 18:10
@susburrows susburrows mentioned this pull request May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AaronDonahue AaronDonahue

Labels
Atmosphere BFB PR leaves answers BFB bug fix PR
Projects
None yet
Milestone
No milestone
4 participants
@ndkeen @singhbalwinder @rljacob @AaronDonahue