Correct ocn_co2_type setting for bcrd case #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltrud
approved these changes
Nov 7, 2019
jonbob
added a commit
that referenced
this pull request
Nov 7, 2019
Correct ocn_co2_type setting for bcrd case This PR brings in a bug fix to correct the ocn_co2_type setting for bcrd cases in the maint-1.1 branch Fixes #3289 [BFB]
|
merged to maint-1.1 |
|
@rljacob - it does change answers for tests run out-of-the-box. My understanding is that this change was implemented in the run_e3sm script but also committed to the repo to make sure it didn't get lost. |
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
These variables should be initialized even if for some reason the namelist isn't read. Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: [bit for bit, roundoff, climate changing] Fixes (See issue) #3294 User interface changes?: Update gh-pages html (Y/N)?: Code review:
rljacob
pushed a commit
that referenced
this pull request
Apr 21, 2021
These variables should get reasonable initial values if the namelist isn't read. Test suite: scripts_regression_tests.py had testing of SMS_Ld5.f09_g17.B1850G.cheyenne_intel.allactive-cism-test_coupling Test baseline: Test namelist changes: Test status: bit for bit Fixes #3294 User interface changes?: Update gh-pages html (Y/N)?: Code review:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in a bug fix to correct the ocn_co2_type setting for bcrd cases in the maint-1.1 branch
Fixes #3289
[BFB]