Update machine file on theta #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rljacob
reviewed
Aug 28, 2019
| @@ -207,6 +207,11 @@ subroutine tridag_solve & | |||
|
|
|||
| use clubb_precision, only: & | |||
| core_rknd ! Variable(s) | |||
| #ifndef NDEBUG | |||
There was a problem hiding this comment.
You don't have to fix this but noting that double negative logic is not good form.
There was a problem hiding this comment.
I agree. Assuming DEBUG is not defined, we can add the following on top of the code to define it and then use DEBUG in the logic instead of NDEBUG:
#define DEBUG
#ifdef NDEBUG
#undef DEBUG
#endif
I have not tested the above, so I am not sure if it will work. But, like @rljacob mentioned, you don't have to fix it.
rljacob
approved these changes
Aug 28, 2019
singhbalwinder
approved these changes
Aug 29, 2019
3b13d78 to
5643fdf
Compare
amametjanov
added a commit
that referenced
this pull request
Aug 30, 2019
Update machine file on theta. Also, turn off a div-by-zero check for debug+knl+intel runs. Fixes #3098 [BFB]
amametjanov
added a commit
that referenced
this pull request
Sep 6, 2019
Update machine file on theta Also, turn off a div-by-zero check for debug+knl+intel runs. Fixes #3098 [BFB]
jgfouca
pushed a commit
to ESMCI/cime
that referenced
this pull request
Oct 25, 2019
Update machine file on theta Also, turn off a div-by-zero check for debug+knl+intel runs. Fixes E3SM-Project/E3SM#3098 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, turn off a div-by-zero check for debug+knl+intel runs.
Fixes #3098
[BFB]