-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random number generation fix for the prescribed aerosols in CAM #312
Random number generation fix for the prescribed aerosols in CAM #312
Conversation
This commit passes the acme developer tests. It changes answers only for the prescribed aerosols run as it is using a new random number generator. |
…to next (PR #312) Random number generation fix for the prescribed aerosols in CAM. This commit fixes the random number generation bug in prescribed aerosols routine. Please see issue #246 for more details. The fix make use of KISSVEC random number generator instead of the Fortran intrinsic. This commit passes the acme developer tests. It changes answers only for the prescribed aerosols run as it is using a new random number generator. Fixes #246 [non-BFB] AG-343
merged this to "next" today. |
Since there are no (new) test failures on "next", I am merging this to "master". |
…#312) Random number generation fix for the prescribed aerosols in CAM This commit fixes the random number generation bug in prescribed aerosols routine. Please see issue #246 for more details.The fix make use of KISSVEC random number generator instead of the Fortran intrinsic. This commit passes the acme developer tests. It changes answers only for the prescribed aerosols run as it is using a new random number generator. Fixes #246 [non-BFB] AG-343
What is this tmp.branch.info file in the top level directory? |
I create this file for my testing purposes. This should not be included in the commit and should be removed (my mistake). Should I go ahead and remove it by creating a branch or is there any other easier way to do it? |
The most straightforward way to remove the file is to create a branch in which the file is removed, and then creating a new pull request for it. |
Ok. Thanks Jeff. I will create a branch from the point where this branch is merged into the master, delete the file and issue a PR. |
Sorry, I should have caught this when reviewing the PR. Thanks for pointing it out. I'll merge Balwinder's change that removes this extraneous file. |
Adds depth-averaged Rayleigh drag option and cleans up implicit Rayleigh drag into its own subroutine. * ocean/coastal_depth_avg_rayleigh: Cleans up implicit vertical solve Adds option to apply depth-dependent Rayleigh drag
* add CONUS RRM support for lat-lon * address code review
This commit fixes the random number generation bug in prescribed
aerosols routine. Please see issue #246 for more details.The fix
make use of KISSVEC random number generator instead of the Fortran
intrinsic.
Fixes #246
[non-BFB]
AG-343