Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random number generation fix for the prescribed aerosols in CAM #312

Merged

Conversation

singhbalwinder
Copy link
Contributor

This commit fixes the random number generation bug in prescribed
aerosols routine. Please see issue #246 for more details.The fix
make use of KISSVEC random number generator instead of the Fortran
intrinsic.

Fixes #246
[non-BFB]
AG-343

This commit fixes the random number generation bug in prescribed
aerosols routine. Please see issue #246 for more details.The fix
make use of KISSVEC random number generator instead of the Fortran
intrinsic.

Fixes #246
[non-BFB]
AG-343
@singhbalwinder
Copy link
Contributor Author

This commit passes the acme developer tests. It changes answers only for the prescribed aerosols run as it is using a new random number generator.

susburrows added a commit that referenced this pull request Aug 31, 2015
…to next (PR #312)

Random number generation fix for the prescribed aerosols in CAM.

This commit fixes the random number generation bug in prescribed
aerosols routine. Please see issue #246 for more details.  The fix
make use of KISSVEC random number generator instead of the Fortran
intrinsic.

This commit passes the acme developer tests. It changes answers only
for the prescribed aerosols run as it is using a new random number
generator.

Fixes #246
[non-BFB]
AG-343
@susburrows
Copy link
Contributor

merged this to "next" today.

@susburrows
Copy link
Contributor

Since there are no (new) test failures on "next", I am merging this to "master".

@susburrows susburrows merged commit 389d0ae into master Sep 2, 2015
susburrows added a commit that referenced this pull request Sep 2, 2015
…#312)

Random number generation fix for the prescribed aerosols in CAM

This commit fixes the random number generation bug in prescribed
aerosols routine. Please see issue #246 for more details.The fix
make use of KISSVEC random number generator instead of the Fortran
intrinsic.

This commit passes the acme developer tests. It changes answers only
for the prescribed aerosols run as it is using a new random number
generator.

Fixes #246
[non-BFB]
AG-343
@susburrows susburrows deleted the singhbalwinder/atm/fix-prescribed-aero-rand-num-gen branch September 2, 2015 04:50
@rljacob
Copy link
Member

rljacob commented Sep 3, 2015

What is this tmp.branch.info file in the top level directory?

@singhbalwinder
Copy link
Contributor Author

I create this file for my testing purposes. This should not be included in the commit and should be removed (my mistake). Should I go ahead and remove it by creating a branch or is there any other easier way to do it?

@jeff-cohere
Copy link
Contributor

The most straightforward way to remove the file is to create a branch in which the file is removed, and then creating a new pull request for it.

@singhbalwinder
Copy link
Contributor Author

Ok. Thanks Jeff. I will create a branch from the point where this branch is merged into the master, delete the file and issue a PR.

@susburrows
Copy link
Contributor

Sorry, I should have caught this when reviewing the PR. Thanks for pointing it out. I'll merge Balwinder's change that removes this extraneous file.

jonbob pushed a commit that referenced this pull request Jun 22, 2021
Adds depth-averaged Rayleigh drag option and cleans up implicit
Rayleigh drag into its own subroutine.

* ocean/coastal_depth_avg_rayleigh:
  Cleans up implicit vertical solve
  Adds option to apply depth-dependent Rayleigh drag
jonbob pushed a commit that referenced this pull request Jun 22, 2021
This PR is an accumulation of PRs into the ocean/coastal branch. We are
bringing them in at once for efficiency:
 #285, #289, #284, #295, #310, #311, #312, #335, #354, #356, #358, #359,
 #365, #371
yunpengshan2014 pushed a commit that referenced this pull request Apr 2, 2024
* add CONUS RRM support for lat-lon

* address code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prescribed aerosols modal treatment produces erroneous random number distributions
4 participants