Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused homme folders #3070

Merged
merged 4 commits into from
Aug 16, 2019
Merged

Remove unused homme folders #3070

merged 4 commits into from
Aug 16, 2019

Conversation

oksanaguba
Copy link
Contributor

@oksanaguba oksanaguba commented Jul 15, 2019 •
edited
Loading

Removes theta, pese, and vertical_se folders and theta, pese execs.

[bfb]

@oksanaguba oksanaguba requested a review from mt5555 July 15, 2019 00:45
@oksanaguba oksanaguba self-assigned this Jul 15, 2019
@oksanaguba oksanaguba added HOMME standalone issues with the standalone HOMME code that dont impact E3SM BFB PR leaves answers BFB labels Jul 15, 2019
@oksanaguba oksanaguba changed the title Remove unused homme folders [wip] Remove unused homme folders Jul 16, 2019
@mt5555
Copy link
Contributor

mt5555 commented Jul 26, 2019

two more things to remove: the #ifdef VERTICAL_INTERPOLATION in prim_main.F90, as well as the netcdf_interp_mod.F90 routine.

@oksanaguba
Copy link
Contributor Author

oksanaguba commented Aug 8, 2019 •
edited
Loading

VERT_INTERP was removed, with relevant lines/file. HOMME suite passes on anvil with NLDIFF which is not related to this PR (baselines are probably old)

2019-08-08 12:09:24: NLCOMP
Comparison failed between '/lcrc/group/acme/onguba/acme_scratch/anvil/HOMME_P24.f19_g16_rx1.A.anvil_intel.C.20190808_120917_mhn3hb/CaseDocs/drv_in' with '/home/onguba/as/acme-tests/master/HOMME_P24.f19_g16_rx1.A.anvil_intel/CaseDocs/drv_in'
  BASE: eps_ogrid = 0.1
  COMP: eps_ogrid = 0.01

This is ready.

@oksanaguba oksanaguba changed the title [wip] Remove unused homme folders Remove unused homme folders Aug 8, 2019
oksanaguba added a commit that referenced this pull request Aug 15, 2019
@oksanaguba
Merge branch 'oksanaguba/homme/remove-folders' into next (PR #3070)
a76a145 
Removes theta, pese, and vertical_se folders and theta, pese execs.

[bfb]
@oksanaguba
Copy link
Contributor Author

Ran against today's next after JGF commit at noon, passed on skybridge. Merged to next.

oksanaguba added a commit that referenced this pull request Aug 16, 2019
@oksanaguba
Merge remote-tracking branch 'oksanaguba/homme/remove-folders' into m…
a96657c 
…aster (PR #3070)

Removes theta, pese, and vertical_se folders and theta, pese execs.

[bfb]
@oksanaguba oksanaguba merged commit 0e06117 into master Aug 16, 2019
@oksanaguba oksanaguba deleted the oksanaguba/homme/remove-folders branch August 16, 2019 21:10
jgfouca pushed a commit that referenced this pull request Nov 7, 2024
@bartgol
Merge pull request #3070 from E3SM-Project/mahf708/io/allow-rank-0
a8bbcff 
enable outputing rank-0 fields in IO
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mt5555 mt5555 mt5555 approved these changes

Assignees

@oksanaguba oksanaguba

Labels
BFB PR leaves answers BFB HOMME standalone issues with the standalone HOMME code that dont impact E3SM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oksanaguba @mt5555